[Backport 2.x] Enable support for default model id on HybridQueryBuilder #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Enable support for default model id on HybridQueryBuilder Signed-off-by: Varun Jain <[email protected]> * Adding tests and updating changelog.md Signed-off-by: Varun Jain <[email protected]> * Optimizing code Signed-off-by: Varun Jain <[email protected]> * modyfing the tests4 Signed-off-by: Varun Jain <[email protected]> * Addressing Heemin comment Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]> (cherry picked from commit 98e5534)
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #549 +/- ##
============================================
+ Coverage 85.18% 85.24% +0.05%
- Complexity 541 543 +2
============================================
Files 40 40
Lines 1580 1586 +6
Branches 248 249 +1
============================================
+ Hits 1346 1352 +6
Misses 117 117
Partials 117 117 ☔ View full report in Codecov by Sentry. |
martin-gaievski
approved these changes
Jan 23, 2024
heemin32
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 98e5534 from #541