Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Added release notes for 2.10 release (#277) #287

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

navneet1v
Copy link
Collaborator

Description

Added release notes for 2.10 release (#277)

Issues Resolved

#224

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@navneet1v navneet1v added skip-changelog backport 2.10 backport to 2.10 branch labels Sep 6, 2023
@navneet1v navneet1v changed the title Added release notes for 2.10 release (#277) [Backport 2.x] Added release notes for 2.10 release (#277) Sep 6, 2023
@navneet1v
Copy link
Collaborator Author

The build is failing due to :

Exception in thread "main" java.lang.IllegalStateException: failed to load plugin opensearch-ml due to jar hell
| 	at org.opensearch.plugins.PluginsService.checkBundleJarHell(PluginsService.java:681)
| 	at org.opensearch.plugins.InstallPluginCommand.jarHellCheck(InstallPluginCommand.java:862)
| 	at org.opensearch.plugins.InstallPluginCommand.loadPluginInfo(InstallPluginCommand.java:830)
| 	at org.opensearch.plugins.InstallPluginCommand.installPlugin(InstallPluginCommand.java:875)
| 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:276)
| 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:250)
| 	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
| 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
| 	at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
| 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
| 	at org.opensearch.cli.Command.main(Command.java:101)
| 	at org.opensearch.plugins.PluginCli.main(PluginCli.java:60)
| Caused by: java.lang.IllegalStateException: jar hell!
| class: org.apache.commons.lang3.AnnotationUtils$1
| jar1: /home/runner/work/neural-search/neural-search/build/testclusters/integTest-0/distro/2.10.0-ARCHIVE/lib/commons-lang3-3.13.0.jar
| jar2: /home/runner/work/neural-search/neural-search/build/testclusters/integTest-0/distro/2.10.0-ARCHIVE/plugins/.installing-40852478789188[98](https://github.com/opensearch-project/neural-search/actions/runs/6093097774/job/16532212834?pr=287#step:4:99)473/commons-lang3-3.10.jar
| 	at org.opensearch.bootstrap.JarHell.checkClass(JarHell.java:316)
| 	at org.opensearch.bootstrap.JarHell.checkJarHell(JarHell.java:215)
| 	at org.opensearch.plugins.PluginsService.checkBundleJarHell(PluginsService.java:679)
| 	... 11 more

@navneet1v navneet1v force-pushed the 2.x branch 2 times, most recently from e995539 to 4e50a8c Compare September 6, 2023 05:39
@navneet1v
Copy link
Collaborator Author

Resolved the apache commons dependency which was coming from core.

(base) 22:36 ~/workplace/neural-search 2.x$ ./gradlew :dependencyInsight --configuration resolveableCompileOnly --dependency org.apache.commons:commons-lang3
Picked up JAVA_TOOL_OPTIONS: -Dlog4j2.formatMsgNoLookups=true
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.1.1
  OS Info               : Mac OS X 12.6.8 (x86_64)
  JDK Version           : 11 (Eclipse Temurin JDK)
  JAVA_HOME             : /Users/navneev/.sdkman/candidates/java/11.0.16-tem
  Random Testing Seed   : B3553F4A6A551760
  In FIPS 140 mode      : false
=======================================

> Task :dependencyInsight
Dependency resolution failed because of conflict(s) on the following module(s):
   - org.apache.commons:commons-lang3 between versions 3.13.0 and 3.10

org.apache.commons:commons-lang3:3.13.0
  Variant runtime:
    | Attribute Name             | Provided     | Requested |
    |----------------------------|--------------|-----------|
    | org.gradle.category        | library      |           |
    | org.gradle.libraryelements | jar          |           |
    | org.gradle.status          | release      |           |
    | org.gradle.usage           | java-runtime |           |
   Selection reasons:
      - By conflict resolution: between versions 3.13.0 and 3.10

org.apache.commons:commons-lang3:3.13.0
\--- org.opensearch:opensearch-encryption-sdk:2.10.0-SNAPSHOT:20230906.043946-24
     \--- org.opensearch:opensearch:2.10.0-SNAPSHOT:20230906.043946-240
          \--- resolveableCompileOnly

org.apache.commons:commons-lang3:3.10 -> 3.13.0
\--- resolveableCompileOnly

A web-based, searchable dependency report is available by adding the --scan option.

BUILD SUCCESSFUL in 716ms

@navneet1v navneet1v force-pushed the 2.x branch 2 times, most recently from 67bff04 to 54a136c Compare September 6, 2023 07:41
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #287 (f382d8e) into 2.x (d0ed52e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x     #287   +/-   ##
=========================================
  Coverage     85.77%   85.77%           
  Complexity      376      376           
=========================================
  Files            30       30           
  Lines          1104     1104           
  Branches        168      168           
=========================================
  Hits            947      947           
  Misses           83       83           
  Partials         74       74           

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@navneet1v navneet1v merged commit adecea5 into opensearch-project:2.x Sep 7, 2023
34 of 42 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
Signed-off-by: Navneet Verma <[email protected]>
(cherry picked from commit adecea5)
navneet1v added a commit that referenced this pull request Sep 7, 2023
Signed-off-by: Navneet Verma <[email protected]>
(cherry picked from commit adecea5)

Co-authored-by: Navneet Verma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.10 backport to 2.10 branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants