Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch pull_request_target to pull_request in CI #26

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

jmazanec15
Copy link
Member

Description

Right now, our CI checks out the base branch instead of merge branch (see #25 (comment))

Switch pull_request_target to pull_request in CI.

pull_request_target uses base as a context, while pull_request will use merge context. More info can be found: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jmazanec15 jmazanec15 requested a review from a team October 20, 2022 17:08
@jmazanec15
Copy link
Member Author

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@jmazanec15 jmazanec15 merged commit 094bf0b into opensearch-project:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants