Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline owners and maintainers #170

Merged
merged 1 commit into from
May 10, 2023

Conversation

martin-gaievski
Copy link
Member

Description

Baseline owners and maintainers

Issues Resolved

#111

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Martin Gaievski <[email protected]>
@martin-gaievski martin-gaievski added backport 2.x Label will add auto workflow to backport PR to 2.x branch skip-changelog labels May 10, 2023
@martin-gaievski martin-gaievski requested a review from a team May 10, 2023 19:34
@martin-gaievski
Copy link
Member Author

build is currently failing due to known issues with plugin and some dependencies, not caused/related to changes in this PR

@dblock
Copy link
Member

dblock commented May 10, 2023

Looks good, merging.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-170-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d933b11bf03a991f0825637351aae5f87e23ba9d
# Push it to GitHub
git push --set-upstream origin backport/backport-170-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-170-to-2.x.

martin-gaievski added a commit to martin-gaievski/neural-search that referenced this pull request May 11, 2023
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit d933b11)
martin-gaievski added a commit that referenced this pull request May 12, 2023
* Baseline owners and maintainers (#170)

Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit d933b11)

* Add allow_registering_model_via_url as integ test use custom model

Signed-off-by: Martin Gaievski <[email protected]>

* Add hash for test model

Signed-off-by: Martin Gaievski <[email protected]>

* Fix model deployment after recent redeploy feature in ml-commons

Signed-off-by: Martin Gaievski <[email protected]>

---------

Signed-off-by: Martin Gaievski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants