Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reflection dependency #136

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

heemin32
Copy link
Collaborator

@heemin32 heemin32 commented Mar 14, 2023

Description

Add reflection dependency

Issues Resolved

Build is failing due to missing dependency. ml-common excluded reflection from runtime dependency.
opensearch-project/ml-commons@464bfe3

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@heemin32 heemin32 requested a review from a team March 14, 2023 22:30
@heemin32 heemin32 added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Mar 14, 2023
Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that after this change tests are ok? I've been checking in 2.x, for me it kept failing on document upload unless I added two more dependencies:

    common_utils_version = System.getProperty("common_utils.version", opensearch_build)
    ...
    implementation group: 'org.javassist', name: 'javassist', version: '3.29.2-GA'
    implementation group: 'org.opensearch', name: 'common-utils', version: "${common_utils_version}"

@martin-gaievski
Copy link
Member

Did you check that after this change tests are ok? I've been checking in 2.x, for me it kept failing on document upload unless I added two more dependencies:

    common_utils_version = System.getProperty("common_utils.version", opensearch_build)
    ...
    implementation group: 'org.javassist', name: 'javassist', version: '3.29.2-GA'
    implementation group: 'org.opensearch', name: 'common-utils', version: "${common_utils_version}"

Ok, I see it's failing for you as well: https://github.com/opensearch-project/neural-search/actions/runs/4420785422/jobs/7750894854. Please add those two dependencies from my previous comment, it should solve it

@heemin32 heemin32 force-pushed the reflection branch 3 times, most recently from 329b205 to 984dd07 Compare March 14, 2023 23:12
Signed-off-by: Heemin Kim <[email protected]>
@heemin32 heemin32 merged commit 96ce34e into opensearch-project:main Mar 15, 2023
@heemin32 heemin32 deleted the reflection branch March 15, 2023 00:13
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2023
Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit 96ce34e)
heemin32 added a commit that referenced this pull request Mar 15, 2023
Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit 96ce34e)

Co-authored-by: Heemin Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants