-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reflection dependency #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check that after this change tests are ok? I've been checking in 2.x, for me it kept failing on document upload unless I added two more dependencies:
common_utils_version = System.getProperty("common_utils.version", opensearch_build)
...
implementation group: 'org.javassist', name: 'javassist', version: '3.29.2-GA'
implementation group: 'org.opensearch', name: 'common-utils', version: "${common_utils_version}"
Ok, I see it's failing for you as well: https://github.com/opensearch-project/neural-search/actions/runs/4420785422/jobs/7750894854. Please add those two dependencies from my previous comment, it should solve it |
329b205
to
984dd07
Compare
Signed-off-by: Heemin Kim <[email protected]>
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 96ce34e)
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 96ce34e) Co-authored-by: Heemin Kim <[email protected]>
Description
Add reflection dependency
Issues Resolved
Build is failing due to missing dependency. ml-common excluded reflection from runtime dependency.
opensearch-project/ml-commons@464bfe3
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.