Fixed failed test after knn added multiple inner hits feature #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
added
backport 2.x
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
heemin32
approved these changes
Dec 17, 2024
ryanbogan
approved these changes
Dec 17, 2024
naveentatikonda
approved these changes
Dec 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 3d72cc3)
martin-gaievski
added a commit
that referenced
this pull request
Dec 17, 2024
#1027) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 3d72cc3) Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Need to fix some unit tests after recent k-NN feature "Support for Multi Values in innerHit for Nested k-NN Fields in Lucene and FAISS" opensearch-project/k-NN#2283
Check List
[ ] New functionality includes testing.[ ] New functionality has been documented.[ ] API changes companion pull request created.--signoff.[ ] Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.