Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI to use pull_request #1009

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

ryanbogan
Copy link
Member

@ryanbogan ryanbogan commented Dec 12, 2024

Description

Changes the CI to use pull_request instead of pull_request_target. This will result in codecov only running a few times per day then running out of quota

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (3c7f275) to head (668fe41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1009      +/-   ##
============================================
- Coverage     80.47%   80.21%   -0.27%     
  Complexity     1000     1000              
============================================
  Files            78       78              
  Lines          3411     3411              
  Branches        578      578              
============================================
- Hits           2745     2736       -9     
- Misses          425      433       +8     
- Partials        241      242       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Bogan <[email protected]>
Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you Ryan!

@minalsha
Copy link
Collaborator

LGTM

@martin-gaievski martin-gaievski merged commit 7feacd6 into opensearch-project:main Dec 12, 2024
47 checks passed
@martin-gaievski martin-gaievski added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Dec 12, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 12, 2024
* Change CI to use pull_request

Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit 7feacd6)
@ryanbogan ryanbogan deleted the update_ci branch December 12, 2024 22:07
heemin32 pushed a commit that referenced this pull request Dec 14, 2024
* Change CI to use pull_request

Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit 7feacd6)

Co-authored-by: Ryan Bogan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch security fix skip-changelog v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants