adding model content hash value #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhrubo Saha <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #885 +/- ##
=========================================
Coverage 84.18% 84.18%
Complexity 1757 1757
=========================================
Files 139 139
Lines 6752 6753 +1
Branches 673 673
=========================================
+ Hits 5684 5685 +1
Misses 771 771
Partials 297 297
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Could you add a UT to cover this hash value test? |
ylwu-amzn
previously approved these changes
May 5, 2023
I have plan to add integration test for metrics correlation and it should be covered there i think. |
Signed-off-by: Dhrubo Saha <[email protected]>
jngz-es
approved these changes
May 5, 2023
ylwu-amzn
approved these changes
May 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 5, 2023
* adding model content hash value Signed-off-by: Dhrubo Saha <[email protected]> * addressed comment Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit 134e065)
dhrubo-os
added a commit
that referenced
this pull request
May 5, 2023
* adding model content hash value Signed-off-by: Dhrubo Saha <[email protected]> * addressed comment Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit 134e065) Co-authored-by: Dhrubo Saha <[email protected]>
zane-neo
pushed a commit
to zane-neo/ml-commons
that referenced
this pull request
Aug 24, 2023
* adding model content hash value Signed-off-by: Dhrubo Saha <[email protected]> * addressed comment Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]>
5 tasks
zane-neo
added a commit
that referenced
this pull request
Aug 24, 2023
* adding model content hash value * addressed comment --------- Signed-off-by: Dhrubo Saha <[email protected]> Co-authored-by: Dhrubo Saha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding model content hash value
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.