Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to main] add more parameters for text embedding model (#640) #756

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Backport PR #640 to main branch.

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* add more parameters for text embedding model

Signed-off-by: Yaliang Wu <[email protected]>

* upgrade junit version to 4.13.2

Signed-off-by: Yaliang Wu <[email protected]>

* address comments

Signed-off-by: Yaliang Wu <[email protected]>

Signed-off-by: Yaliang Wu <[email protected]>
@ylwu-amzn ylwu-amzn requested a review from a team February 28, 2023 05:40
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #756 (bef97c8) into main (a08e482) will increase coverage by 0.33%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #756      +/-   ##
============================================
+ Coverage     84.55%   84.89%   +0.33%     
- Complexity      986      990       +4     
============================================
  Files            92       92              
  Lines          3542     3542              
  Branches        326      326              
============================================
+ Hits           2995     3007      +12     
+ Misses          410      399      -11     
+ Partials        137      136       -1     
Flag Coverage Δ
ml-commons 84.89% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../opensearch/ml/action/handler/MLSearchHandler.java 86.66% <ø> (ø)
...earch/ml/action/load/TransportLoadModelAction.java 89.32% <ø> (ø)
...ml/action/load/TransportLoadModelOnNodeAction.java 94.44% <ø> (ø)
...arch/ml/action/models/GetModelTransportAction.java 78.78% <ø> (ø)
...earch/ml/action/profile/MLProfileNodeResponse.java 89.18% <ø> (ø)
...pensearch/ml/action/profile/MLProfileResponse.java 94.73% <ø> (ø)
...pensearch/ml/action/stats/MLStatsNodeResponse.java 95.65% <ø> (ø)
...ensearch/ml/action/stats/MLStatsNodesResponse.java 94.73% <ø> (ø)
.../ml/action/syncup/TransportSyncUpOnNodeAction.java 93.93% <ø> (ø)
...search/ml/action/tasks/GetTaskTransportAction.java 78.12% <ø> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ylwu-amzn ylwu-amzn merged commit 393f12b into opensearch-project:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants