Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the inheritance of the BWC test file #692

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Jan 11, 2023

Signed-off-by: Sicheng Song [email protected]

Description

Change the inheritance of the MLCommonsBackwardsCompatibilityIT.java to be extended from MLCommonsBackwardsCompatibilityRestTestCase.java, which previously from MLCommonsRestTestCase.java

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@b4sjoo b4sjoo requested a review from a team January 11, 2023 02:36
ylwu-amzn
ylwu-amzn previously approved these changes Jan 11, 2023
jngz-es
jngz-es previously approved these changes Jan 11, 2023
Signed-off-by: Sicheng Song <[email protected]>
@b4sjoo b4sjoo dismissed stale reviews from jngz-es and ylwu-amzn via 1d04132 January 11, 2023 02:44
@b4sjoo b4sjoo requested review from jngz-es and ylwu-amzn January 11, 2023 02:44
@codecov-commenter
Copy link

Codecov Report

Merging #692 (1d04132) into 2.x (e37ab93) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #692      +/-   ##
============================================
+ Coverage     84.13%   84.18%   +0.05%     
- Complexity     1010     1035      +25     
============================================
  Files            93       99       +6     
  Lines          3662     3738      +76     
  Branches        343      344       +1     
============================================
+ Hits           3081     3147      +66     
- Misses          436      445       +9     
- Partials        145      146       +1     
Flag Coverage Δ
ml-commons 84.18% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/opensearch/ml/plugin/MachineLearningPlugin.java 98.82% <0.00%> (-1.18%) ⬇️
...main/java/org/opensearch/ml/utils/MLNodeUtils.java 94.44% <0.00%> (ø)
.../org/opensearch/ml/settings/MLCommonsSettings.java 100.00% <0.00%> (ø)
...nsearch/ml/breaker/NativeMemoryCircuitBreaker.java 84.61% <0.00%> (ø)
...opensearch/ml/breaker/MLCircuitBreakerService.java 100.00% <0.00%> (ø)
...in/java/org/opensearch/ml/breaker/BreakerName.java 100.00% <0.00%> (ø)
...opensearch/ml/breaker/ThresholdCircuitBreaker.java 100.00% <0.00%> (ø)
.../org/opensearch/ml/breaker/DiskCircuitBreaker.java 36.36% <0.00%> (ø)
...rg/opensearch/ml/breaker/MemoryCircuitBreaker.java 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@b4sjoo b4sjoo merged commit 83a7d4f into opensearch-project:2.x Jan 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2023
* Change the inheritance of the BWC test file

Signed-off-by: Sicheng Song <[email protected]>

* SpotlessApply

Signed-off-by: Sicheng Song <[email protected]>

Signed-off-by: Sicheng Song <[email protected]>
(cherry picked from commit 83a7d4f)
ylwu-amzn pushed a commit that referenced this pull request Jan 11, 2023
* Change the inheritance of the BWC test file

Signed-off-by: Sicheng Song <[email protected]>

* SpotlessApply

Signed-off-by: Sicheng Song <[email protected]>

Signed-off-by: Sicheng Song <[email protected]>
(cherry picked from commit 83a7d4f)

Co-authored-by: Sicheng Song <[email protected]>
b4sjoo added a commit to b4sjoo/ml-commons that referenced this pull request Jan 11, 2023
* Change the inheritance of the BWC test file

Signed-off-by: Sicheng Song <[email protected]>

* SpotlessApply

Signed-off-by: Sicheng Song <[email protected]>

Signed-off-by: Sicheng Song <[email protected]>
@b4sjoo b4sjoo deleted the 2.x_dev branch January 11, 2023 03:44
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Feb 17, 2023
* Change the inheritance of the BWC test file

Signed-off-by: Sicheng Song <[email protected]>

* SpotlessApply

Signed-off-by: Sicheng Song <[email protected]>

Signed-off-by: Sicheng Song <[email protected]>
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 2, 2023
* Change the inheritance of the BWC test file

Signed-off-by: Sicheng Song <[email protected]>

* SpotlessApply

Signed-off-by: Sicheng Song <[email protected]>

Signed-off-by: Sicheng Song <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants