-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the inheritance of the BWC test file #692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sicheng Song <[email protected]>
ylwu-amzn
previously approved these changes
Jan 11, 2023
jngz-es
previously approved these changes
Jan 11, 2023
Signed-off-by: Sicheng Song <[email protected]>
ylwu-amzn
approved these changes
Jan 11, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #692 +/- ##
============================================
+ Coverage 84.13% 84.18% +0.05%
- Complexity 1010 1035 +25
============================================
Files 93 99 +6
Lines 3662 3738 +76
Branches 343 344 +1
============================================
+ Hits 3081 3147 +66
- Misses 436 445 +9
- Partials 145 146 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rbhavna
approved these changes
Jan 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
* Change the inheritance of the BWC test file Signed-off-by: Sicheng Song <[email protected]> * SpotlessApply Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Sicheng Song <[email protected]> (cherry picked from commit 83a7d4f)
ylwu-amzn
pushed a commit
that referenced
this pull request
Jan 11, 2023
* Change the inheritance of the BWC test file Signed-off-by: Sicheng Song <[email protected]> * SpotlessApply Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Sicheng Song <[email protected]> (cherry picked from commit 83a7d4f) Co-authored-by: Sicheng Song <[email protected]>
b4sjoo
added a commit
to b4sjoo/ml-commons
that referenced
this pull request
Jan 11, 2023
* Change the inheritance of the BWC test file Signed-off-by: Sicheng Song <[email protected]> * SpotlessApply Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Sicheng Song <[email protected]>
ylwu-amzn
pushed a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Feb 17, 2023
* Change the inheritance of the BWC test file Signed-off-by: Sicheng Song <[email protected]> * SpotlessApply Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Sicheng Song <[email protected]>
ylwu-amzn
pushed a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Mar 2, 2023
* Change the inheritance of the BWC test file Signed-off-by: Sicheng Song <[email protected]> * SpotlessApply Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Sicheng Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sicheng Song [email protected]
Description
Change the inheritance of the
MLCommonsBackwardsCompatibilityIT.java
to be extended fromMLCommonsBackwardsCompatibilityRestTestCase.java
, which previously fromMLCommonsRestTestCase.java
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.