Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MAINTAINERS.md format #668

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Jan 6, 2023

Signed-off-by: Bhavana Ramaram [email protected]

Description

Updated MAINTAINERS.md to match opensearch-project recommended format.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Bhavana Ramaram <[email protected]>
@rbhavna rbhavna requested a review from a team January 6, 2023 22:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #668 (2f4d370) into 2.x (c220af3) will increase coverage by 0.49%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #668      +/-   ##
============================================
+ Coverage     83.46%   83.96%   +0.49%     
- Complexity      996     1008      +12     
============================================
  Files            93       93              
  Lines          3660     3660              
  Branches        342      342              
============================================
+ Hits           3055     3073      +18     
+ Misses          460      443      -17     
+ Partials        145      144       -1     
Flag Coverage Δ
ml-commons 83.96% <ø> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/ml/task/MLTaskManager.java 61.92% <0.00%> (+2.53%) ⬆️
.../ml/action/syncup/TransportSyncUpOnNodeAction.java 89.79% <0.00%> (+4.08%) ⬆️
...n/java/org/opensearch/ml/cluster/MLSyncUpCron.java 93.75% <0.00%> (+6.25%) ⬆️
...org/opensearch/ml/cluster/DiscoveryNodeHelper.java 98.48% <0.00%> (+9.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@b4sjoo b4sjoo merged commit ed94380 into opensearch-project:2.x Jan 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 9, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-668-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed94380c6c2238d425a1be2afbbde8b88b1dcca4
# Push it to GitHub
git push --set-upstream origin backport/backport-668-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport/backport-668-to-2.5.

rbhavna added a commit to rbhavna/ml-commons that referenced this pull request Jan 9, 2023
rbhavna added a commit to rbhavna/ml-commons that referenced this pull request Jan 9, 2023
(cherry picked from commit ed94380)
Signed-off-by: Bhavana Ramaram <[email protected]>
rbhavna added a commit that referenced this pull request Jan 9, 2023
(cherry picked from commit ed94380)
Signed-off-by: Bhavana Ramaram <[email protected]>
@b4sjoo b4sjoo added the documentation Improvements or additions to documentation label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.5 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants