change task worker node to list; add target worker node to cache #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #656 +/- ##
============================================
+ Coverage 84.58% 84.62% +0.03%
- Complexity 998 1001 +3
============================================
Files 93 93
Lines 3582 3597 +15
Branches 325 327 +2
============================================
+ Hits 3030 3044 +14
+ Misses 417 415 -2
- Partials 135 138 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
b4sjoo
previously approved these changes
Dec 31, 2022
Signed-off-by: Yaliang Wu <[email protected]>
b4sjoo
previously approved these changes
Dec 31, 2022
Signed-off-by: Yaliang Wu <[email protected]>
b4sjoo
approved these changes
Dec 31, 2022
jngz-es
reviewed
Dec 31, 2022
Comment on lines
+256
to
+259
| } else { | ||
| String[] nodes = parser.text().split(","); | ||
| workerNodes = Arrays.asList(nodes); | ||
| } |
There was a problem hiding this comment.
We can't go into this branch, right?
There was a problem hiding this comment.
For old ML tasks, the worker nodes saved as String, for example "node1,node2,node3". This branch is for BWC. When user get old ML task, will go to this branch.
| workerNodes = ConcurrentHashMap.newKeySet(); | ||
| modelInferenceDurationQueue = new ConcurrentLinkedQueue<>(); | ||
| predictRequestDurationQueue = new ConcurrentLinkedQueue<>(); | ||
| } | ||
|
|
||
| public void setTargetWorkerNodes(List<String> targetWorkerNodes) { |
There was a problem hiding this comment.
Here targetWorkerNodes is a private concurrent set, so I assume MLModelCache needs to be threadsafe. In this case, if setTargetWorkerNodes can be run by multi-threads, we need to protect it by synchronize, otherwise, the targetWorkerNodes could be wrong.
There was a problem hiding this comment.
This method will be used by MLModelCacheHelper.initModelState method, which already has synchronize
jngz-es
approved these changes
Jan 3, 2023
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Feb 17, 2023
…nsearch-project#656) * change task worker node to list; add target worker node to cache Signed-off-by: Yaliang Wu <[email protected]> * fix target worker node field name Signed-off-by: Yaliang Wu <[email protected]> * support work nodes string in old tasks Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Mar 2, 2023
…nsearch-project#656) * change task worker node to list; add target worker node to cache Signed-off-by: Yaliang Wu <[email protected]> * fix target worker node field name Signed-off-by: Yaliang Wu <[email protected]> * support work nodes string in old tasks Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]>
Merged
5 tasks
ylwu-amzn
added a commit
that referenced
this pull request
Mar 2, 2023
… (#769) * change task worker node to list; add target worker node to cache * fix target worker node field name * support work nodes string in old tasks Signed-off-by: Yaliang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaliang Wu [email protected]
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.