-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address CVE-2022-42889 by updating commons-text #487
Conversation
Signed-off-by: Andriy Redko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.0 has breaking change so CI build failed. This change LGTM. Will approve and merge.
@reta should we backport to 2.x? |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-487-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 479f178f4170cf3d01588f9aec72259fcba6ade6
# Push it to GitHub
git push --set-upstream origin backport/backport-487-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Yes, I will take of that, thanks @ylwu-amzn |
Thanks for addressing this so quickly @reta! Would it be possible to have this backported to 1.x as well? If I understand correctly the 1 major version is still within its maintenance window and addressing CVE-2022-42889 (9.8 score CVE) is probably a suitable security patch to want backported. |
@Ayril sure, will do that shortly, thank you |
Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]>
@reta For better clarity, from which version of 1.x these fixes are available and when it be released? |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-487-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 479f178f4170cf3d01588f9aec72259fcba6ade6
# Push it to GitHub
git push --set-upstream origin backport/backport-487-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
Manually backported to 1.3. #520. |
from OS 1.3.7, these fixes are available and it will be released when 1.3.7 is released. @nslokesh |
Signed-off-by: Andriy Redko [email protected]
Description
Address CVE-2022-42889 by updating commons-text
Issues Resolved
Closes #485
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.