-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix full_response false and no output mapping exceptions #2944
Merged
Zhangxunmt
merged 1 commit into
opensearch-project:main
from
mingshl:main-fix-full-response-path-bug
Sep 13, 2024
Merged
fix full_response false and no output mapping exceptions #2944
Zhangxunmt
merged 1 commit into
opensearch-project:main
from
mingshl:main-fix-full-response-path-bug
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mingshi Liu <[email protected]>
mingshl
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
September 13, 2024 05:50
mingshl
temporarily deployed
to
ml-commons-cicd-env
September 13, 2024 05:50 — with
GitHub Actions
Inactive
mingshl
temporarily deployed
to
ml-commons-cicd-env
September 13, 2024 05:51 — with
GitHub Actions
Inactive
mingshl
temporarily deployed
to
ml-commons-cicd-env
September 13, 2024 06:50 — with
GitHub Actions
Inactive
ohltyler
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the quick fix!
ylwu-amzn
approved these changes
Sep 13, 2024
Zhangxunmt
approved these changes
Sep 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit 853efd6)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.16 2.16
# Navigate to the new working tree
cd .worktrees/backport-2.16
# Create a new branch
git switch --create backport/backport-2944-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 853efd6be34f981740dec99dd649754eb085de83
# Push it to GitHub
git push --set-upstream origin backport/backport-2944-to-2.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.16 Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit 853efd6)
1 task
mingshl
added a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Mingshi Liu <[email protected]>
mingshl
added a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit 853efd6) Co-authored-by: Mingshi Liu <[email protected]>
Zhangxunmt
pushed a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit 853efd6) Co-authored-by: Mingshi Liu <[email protected]>
mingshl
added a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Mingshi Liu <[email protected]>
mingshl
changed the title
fix full_response false and no mapping exceptions
fix full_response false and no output mapping exceptions
Sep 24, 2024
mingshl
added a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Mingshi Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When configuring ml inference processor with full_response_path is false with no output mapping throw exceptions "reason": "An unexpected error occurred: model inference output cannot find field name: $.inference_results"
When ml inference search response processor, configuring no output mapping, then the processors will add the default output mapping as following that will add a field inference_result to the documents or search hits, reading from the json path $.inference_result in the prediction results.
But checking in the ml inference ingest processor, when there is no output mapping, the default output mapping should be
to keep it consistent on ingest and search side, should have the same behaviour for the same mappings.
What is the expected behavior?
when inference processors has no output mapping,
when full_response_path is true, should default add the the entire response from the predict API
when full_response_path is false, should add the prediction results within the tensors
Related Issues
[Resolves #[Issue number to be closed when this PR is merged]
](https://github.com//issues/2943)Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.