add more UT coverage for model/task transport actions #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Zhang <[email protected]>
ylwu-amzn
approved these changes
Mar 31, 2022
amitgalitz
reviewed
Mar 31, 2022
| package org.opensearch.ml.action.models; | ||
|
|
||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.Mockito.*; |
There was a problem hiding this comment.
nit: encouraged not to have .* in imports, I know AD spotless check catches this and you can change ide setting so it doesn't happen
There was a problem hiding this comment.
Cool. Will remove * in the next PR. :)
amitgalitz
reviewed
Mar 31, 2022
| import org.opensearch.ml.common.exception.MLResourceNotFoundException; | ||
| import org.opensearch.test.OpenSearchIntegTestCase; | ||
|
|
||
| @OpenSearchIntegTestCase.ClusterScope(scope = OpenSearchIntegTestCase.Scope.SUITE, numDataNodes = 2) |
There was a problem hiding this comment.
is this needed because we are ingesting a lot of data in this test?
There was a problem hiding this comment.
They are more of ensuring consistency of the test cluster in all IT tests. Check the annotations in other tests. Also the node number not being 1 is to make sure this is tested in multi-node cluster.
There was a problem hiding this comment.
This makes sense, thank you!
ylwu-amzn
pushed a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Apr 22, 2022
…ject#268) Signed-off-by: Xun Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xun Zhang [email protected]
Description
Add UT/IT Coverage for action/models and action/tasks.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.