add support for JDK 17 #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
reviewed
Mar 24, 2022
ml-algorithms/build.gradle
Outdated
| @@ -24,7 +24,7 @@ dependencies { | |||
| implementation files('lib/randomcutforest-parkservices-2.0.1.jar') | |||
| implementation files('lib/randomcutforest-core-2.0.1.jar') | |||
| testImplementation group: 'junit', name: 'junit', version: '4.12' | |||
| testImplementation group: 'org.mockito', name: 'mockito-core', version: '3.9.0' | |||
| testImplementation group: 'org.mockito', name: 'mockito-core', version: '4.4.0' | |||
| testImplementation group: 'org.mockito', name: 'mockito-inline', version: '3.9.0' | |||
There was a problem hiding this comment.
I see the we use latest version of mockito-core. Why not use the latest version of mockito-inline: 4.4.0?
There was a problem hiding this comment.
good catch. this is a left over. should use 4.4 for consistency. Updated in the revision.
Signed-off-by: Xun Zhang <[email protected]>
ylwu-amzn
approved these changes
Mar 24, 2022
jackiehanyang
approved these changes
Mar 24, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To Support build ML-Common using JDK 17, we also need to upgrade the following dependencies.
java.lang.IllegalAccessError: class lombok.javac.apt.LombokProcessor -> upgrade to "io.freefair.lombok" version "6.4.1"
opensearch-ml-algorithms:test errors -> upgrade to name: 'mockito-core', version: '4.4.0'
For be consistent with all plugins -> sourceCompatibility = targetCompatibility = JavaVersion.VERSION_11
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.