Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -Dbuild.version_qualifier in ml common #246

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

Zhangxunmt
Copy link
Collaborator

Description

Add support for -Dbuild.version_qualifier=alpha1.

Issues Resolved

Part of opensearch-project/opensearch-build#1632.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Zhangxunmt Zhangxunmt requested a review from a team March 23, 2022 17:38
Copy link
Collaborator

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems github build CI not triggered. Can you confirm build can pass on your desktop?

@ylwu-amzn
Copy link
Collaborator

ylwu-amzn commented Mar 23, 2022

LGTM. Seems github build CI not triggered. Can you confirm build can pass on your desktop?

Oh, never mind, the build CI running now. Let's wait for the build CI pass

Copy link

@aksingh-es aksingh-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ylwu-amzn ylwu-amzn merged commit cad8451 into opensearch-project:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants