Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error message #1967

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

xinyual
Copy link
Collaborator

@xinyual xinyual commented Jan 31, 2024

Description

fix error message for deploy model and model hash content.
After changing error, when I try:

{
  "name": "all-MiniLM-L6-v2",
  "version": "1.0.0",
  "description": "test model",
  "model_format": "TORCH_SCRIPT",
  "model_config": {
    "model_type": "bert",
    "embedding_dimension": 384,
    "framework_type": "sentence_transformers"
  },
  "url": "https://github.com/opensearch-project/ml-commons/raw/2.x/ml-algorithms/src/test/resources/org/opensearch/ml/engine/algorithms/text_embedding/all-MiniLM-L6-v2_torchscript_sentence-transformer.zip?raw=true"
}

Then get task returns

{
    "task_type": "REGISTER_MODEL",
    "function_name": "TEXT_EMBEDDING",
    "state": "FAILED",
    "worker_node": [
        "YGlxNankSXao_Ztt5VSprA"
    ],
    "create_time": 1706663983561,
    "last_update_time": 1706663991558,
    "error": "Hash code need to be provided when register via url.",
    "is_async": true
}

Issues Resolved

#1630

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (991193c) 82.84% compared to head (f096160) 82.85%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1967   +/-   ##
=========================================
  Coverage     82.84%   82.85%           
- Complexity     5449     5450    +1     
=========================================
  Files           522      522           
  Lines         21912    21915    +3     
  Branches       2228     2229    +1     
=========================================
+ Hits          18154    18157    +3     
  Misses         2847     2847           
  Partials        911      911           
Flag Coverage Δ
ml-commons 82.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinyual xinyual temporarily deployed to ml-commons-cicd-env January 31, 2024 01:55 — with GitHub Actions Inactive
@xinyual xinyual temporarily deployed to ml-commons-cicd-env January 31, 2024 01:55 — with GitHub Actions Inactive
@xinyual xinyual temporarily deployed to ml-commons-cicd-env January 31, 2024 01:55 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit 0fd07f0 into opensearch-project:main Jan 31, 2024
15 of 16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2024
* fix error message

Signed-off-by: xinyual <[email protected]>

* modify error message

Signed-off-by: xinyual <[email protected]>

---------

Signed-off-by: xinyual <[email protected]>
(cherry picked from commit 0fd07f0)
ylwu-amzn pushed a commit that referenced this pull request Jan 31, 2024
* fix error message

Signed-off-by: xinyual <[email protected]>

* modify error message

Signed-off-by: xinyual <[email protected]>

---------

Signed-off-by: xinyual <[email protected]>
(cherry picked from commit 0fd07f0)

Co-authored-by: xinyual <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 19, 2024
* fix error message

Signed-off-by: xinyual <[email protected]>

* modify error message

Signed-off-by: xinyual <[email protected]>

---------

Signed-off-by: xinyual <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants