[Backport 2.x] support charset input params and change default charset as utf8 (#1691) #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…search-project#1691) * support charset input params and change default charset as utf8 Signed-off-by: Yaliang Wu <[email protected]> * add more it Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
changed the title
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1828 +/- ##
============================================
- Coverage 82.46% 82.46% -0.01%
+ Complexity 5316 5315 -1
============================================
Files 510 510
Lines 21445 21446 +1
Branches 2201 2202 +1
============================================
Hits 17685 17685
Misses 2867 2867
- Partials 893 894 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
approved these changes
Dec 30, 2023
mingshl
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport PR #1691 to 2.x
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.