[Backport 2.x] Add search and singular APIs to conversation memory (#1504) #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct#1504) * add searchConversation Signed-off-by: HenryL27 <[email protected]> * add searchinteractions Signed-off-by: HenryL27 <[email protected]> * add searchConversationsITTests Signed-off-by: HenryL27 <[email protected]> * add searchInteractionsITTests Signed-off-by: HenryL27 <[email protected]> * add unit tests for storage-layer search Signed-off-by: HenryL27 <[email protected]> * add Search transport actions and tests Signed-off-by: HenryL27 <[email protected]> * add rest search actions Signed-off-by: HenryL27 <[email protected]> * add search rest actions Signed-off-by: HenryL27 <[email protected]> * Add singular get actions at storage layer Signed-off-by: HenryL27 <[email protected]> * Add OpenSearhMemoryHandler unit tests for singular get Signed-off-by: HenryL27 <[email protected]> * Add singular get transport layer Signed-off-by: HenryL27 <[email protected]> * add singular get rest actions Signed-off-by: HenryL27 <[email protected]> * fix async return value problem Signed-off-by: HenryL27 <[email protected]> * address esay PR comments Signed-off-by: HenryL27 <[email protected]> --------- Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
HenryL27
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt and
austintlee
as code owners
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1720 +/- ##
============================================
+ Coverage 80.82% 81.21% +0.38%
- Complexity 4220 4344 +124
============================================
Files 404 421 +17
Lines 16994 17326 +332
Branches 1819 1830 +11
============================================
+ Hits 13736 14071 +335
+ Misses 2545 2537 -8
- Partials 713 718 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
approved these changes
Dec 1, 2023
dhrubo-os
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Had to do this manually bc apache http library version is different in main and 2.x, which matters when there are new rest ITs
Issues Resolved
#1718
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.