Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blueprint for multi-model titan model #1713

Merged
merged 3 commits into from
Dec 1, 2023
Merged

blueprint for multi-model titan model #1713

merged 3 commits into from
Dec 1, 2023

Conversation

dhrubo-os
Copy link
Collaborator

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhrubo-os dhrubo-os changed the title bluepriint for multi-model titan model blueprint for multi-model titan model Nov 29, 2023
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env November 29, 2023 22:03 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env November 30, 2023 01:12 — with GitHub Actions Inactive
ylwu-amzn
ylwu-amzn reviewed Nov 30, 2023
View reviewed changes
docs/remote_inference_blueprints/bedrock_connector_titan_multimodal_embedding_blueprint.md Outdated
"protocol": "aws_sigv4",
"parameters": {
"region": "<PLEASE ADD YOUR AWS REGION HERE>",
"service_name": "bedrock"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this parameter "input_docs_processed_step_size": 2

ylwu-amzn
ylwu-amzn reviewed Nov 30, 2023
View reviewed changes
docs/remote_inference_blueprints/bedrock_connector_titan_multimodal_embedding_blueprint.md Outdated
```json
POST /_plugins/_ml/models/_register?deploy=true
{
"name": "Bedrock embedding model",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Bedrock embedding model",
"name": "Bedrock multi-modal model",

@dhrubo-os
addressing comment
93b5540 
Signed-off-by: Dhrubo Saha <[email protected]>
@dhrubo-os dhrubo-os merged commit cd482e6 into opensearch-project:main Dec 1, 2023
4 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 1, 2023
@dhrubo-os @github-actions
blueprint for multi-model titan model (#1713)
22db46b 
* bluepriint for multi-model titan model

Signed-off-by: Dhrubo Saha <[email protected]>

* updating comments

Signed-off-by: Dhrubo Saha <[email protected]>

* addressing comment

Signed-off-by: Dhrubo Saha <[email protected]>

---------

Signed-off-by: Dhrubo Saha <[email protected]>
(cherry picked from commit cd482e6)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Dec 1, 2023
Merged
dhrubo-os added a commit that referenced this pull request Dec 1, 2023
@opensearch-trigger-bot @dhrubo-os
blueprint for multi-model titan model (#1713) (#1729)
741a63d 
* bluepriint for multi-model titan model

Signed-off-by: Dhrubo Saha <[email protected]>

* updating comments

Signed-off-by: Dhrubo Saha <[email protected]>

* addressing comment

Signed-off-by: Dhrubo Saha <[email protected]>

---------

Signed-off-by: Dhrubo Saha <[email protected]>
(cherry picked from commit cd482e6)

Co-authored-by: Dhrubo Saha <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
@dhrubo-os @austintlee
blueprint for multi-model titan model (opensearch-project#1713)
0d6499c 
* bluepriint for multi-model titan model

Signed-off-by: Dhrubo Saha <[email protected]>

* updating comments

Signed-off-by: Dhrubo Saha <[email protected]>

* addressing comment

Signed-off-by: Dhrubo Saha <[email protected]>

---------

Signed-off-by: Dhrubo Saha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@Zhangxunmt Zhangxunmt Zhangxunmt approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhrubo-os @Zhangxunmt @ylwu-amzn