-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename the conversation/interaction indices to memory meta/message #1678
rename the conversation/interaction indices to memory meta/message #1678
Conversation
Do we have a name for things we're storing in this new index other than interactions? @navneet1v I think you suggested the name change. Can you sign off on the new names of the indexes? |
fix spotless. |
looks good from my side |
@Zhangxunmt what else are we storing in the 'message' index? Will there be a new resource type called 'message'? |
We have
now index name: How much does it make sense to have I hope in the long run, it doesn't get more confusing. |
The spotless error is coming from the indexMapping Tool. @dhrubo-os The change of the index name only reflects that this index is not only for conversation/interaction. It can be reused for other memory related data like a message (not necessary an interaction), or anything that can be stored as history data. We don't have a concrete idea of what the "message" application_type looks like though. Let's assume this "message" scope is larger than "interaction"? @austintlee |
…ssage Signed-off-by: Xun Zhang <[email protected]>
81e7357
to
3fc5c82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine, but if this can wait a few days, I would also get a sign-off from @HenryL27 .
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/agent_framework_dev #1678 +/- ##
=================================================================
+ Coverage 66.47% 66.54% +0.07%
- Complexity 2525 2530 +5
=================================================================
Files 232 233 +1
Lines 12562 12629 +67
Branches 1269 1278 +9
=================================================================
+ Hits 8350 8404 +54
- Misses 3657 3665 +8
- Partials 555 560 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@HenryL27 , do you still have concerns for this name change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is acceptable
Description
Rename the conversation and interaction indices to memory meta/message based on the discussion in #1614
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.