-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing class casting exception for MachineLearningNodeClient GetMLTask API #1616
Conversation
Signed-off-by: Joshua Palis <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1616 +/- ##
============================================
+ Coverage 79.43% 79.45% +0.01%
- Complexity 3982 3986 +4
============================================
Files 390 390
Lines 16215 16219 +4
Branches 1751 1751
============================================
+ Hits 12881 12887 +6
+ Misses 2660 2657 -3
- Partials 674 675 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 8f690fc)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-feature/agent_framework_dev feature/agent_framework_dev
# Navigate to the new working tree
cd .worktrees/backport-feature/agent_framework_dev
# Create a new branch
git switch --create backport/backport-1616-to-feature/agent_framework_dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f690fc84c0f93fec67a70b74ee01f3b1361033d
# Push it to GitHub
git push --set-upstream origin backport/backport-1616-to-feature/agent_framework_dev
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-feature/agent_framework_dev Then, create a pull request where the |
Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 8f690fc) Co-authored-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Description
Following PR #1560, additional class casting issues have been observed for
getMlTask
Issues Resolved
Coming from opensearch-project/flow-framework#131
Continuation of #1553 and #1580
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.