Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.9] fix no worker node exception for remote embedding model #1483

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 6f83b9f from #1482

* fix no worker node exception for remote embedding model

Signed-off-by: Yaliang Wu <[email protected]>

* only add model info to cache if model cache exist

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 6f83b9f)
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env October 11, 2023 10:05 Inactive
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env October 11, 2023 10:05 Inactive
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1483 (4d5e2c2) into 2.9 (ea14d81) will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##                2.9    #1483      +/-   ##
============================================
+ Coverage     78.49%   78.51%   +0.01%     
- Complexity     2167     2169       +2     
============================================
  Files           168      168              
  Lines          8825     8828       +3     
  Branches        889      890       +1     
============================================
+ Hits           6927     6931       +4     
+ Misses         1496     1494       -2     
- Partials        402      403       +1     
Flag Coverage Δ
ml-commons 78.51% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tion/prediction/TransportPredictionTaskAction.java 62.29% <100.00%> (+1.27%) ⬆️
...va/org/opensearch/ml/model/MLModelCacheHelper.java 78.68% <66.66%> (-0.44%) ⬇️

... and 1 file with indirect coverage changes

@rbhavna rbhavna merged commit aa2337b into 2.9 Oct 11, 2023
@github-actions github-actions bot deleted the backport/backport-1482-to-2.9 branch October 11, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants