Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 2.9]Performance enhacement for predict action by caching model info (#1472) #1481

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Oct 11, 2023

Signed-off-by: zane-neo [email protected]

Description

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…search-project#1472)

* Performance enhacement for predict action by caching model info

Signed-off-by: zane-neo <[email protected]>

* Add context.restore() to avoid missing info

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit a985f6e)
* fix failed ut from PR 1472

Signed-off-by: Yaliang Wu <[email protected]>

* exclude class for low coverage

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env October 11, 2023 06:36 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env October 11, 2023 06:36 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env October 11, 2023 06:36 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env October 11, 2023 06:36 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1481 (384a65b) into 2.9 (513ca39) will decrease coverage by 0.16%.
The diff coverage is 55.55%.

@@             Coverage Diff              @@
##                2.9    #1481      +/-   ##
============================================
- Coverage     78.69%   78.54%   -0.16%     
- Complexity     2166     2172       +6     
============================================
  Files           168      168              
  Lines          8798     8825      +27     
  Branches        883      889       +6     
============================================
+ Hits           6924     6932       +8     
- Misses         1474     1489      +15     
- Partials        400      404       +4     
Flag Coverage Δ
ml-commons 78.54% <55.55%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...va/org/opensearch/ml/model/MLModelCacheHelper.java 79.12% <100.00%> (+0.83%) ⬆️
...ain/java/org/opensearch/ml/model/MLModelCache.java 85.39% <77.77%> (+0.20%) ⬆️
...tion/prediction/TransportPredictionTaskAction.java 61.01% <42.10%> (-17.71%) ⬇️

... and 3 files with indirect coverage changes

@rbhavna rbhavna merged commit ea14d81 into opensearch-project:2.9 Oct 11, 2023
@rbhavna rbhavna deleted the backport/backport-1472-to-2.9 branch October 11, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants