-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added create connector API for MLClient #1437
Added create connector API for MLClient #1437
Conversation
Signed-off-by: Owais Kazi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1437 +/- ##
============================================
- Coverage 78.25% 78.24% -0.01%
Complexity 2308 2308
============================================
Files 193 193
Lines 9449 9455 +6
Branches 942 942
============================================
+ Hits 7394 7398 +4
- Misses 1631 1634 +3
+ Partials 424 423 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
client/src/test/java/org/opensearch/ml/client/MachineLearningNodeClientTest.java
Outdated
Show resolved
Hide resolved
client/src/test/java/org/opensearch/ml/client/MachineLearningNodeClientTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <[email protected]>
client/src/main/java/org/opensearch/ml/client/MachineLearningNodeClient.java
Outdated
Show resolved
Hide resolved
@ylwu-amzn @jngz-es can I get another review on this one? Thanks |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1437-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d265fc7f48b4b17f969b9a589ccde4f5ffd9891e
# Push it to GitHub
git push --set-upstream origin backport/backport-1437-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
@owaiskazi19 could you also please raise a backport PR for 2.x branch? Thanks. |
@dhrubo-os this needs to be merged before backporting this. |
* Adds create connector API for MLClient Signed-off-by: Owais Kazi <[email protected]> * Addressed PR comments Signed-off-by: Owais Kazi <[email protected]> * Addressed PR Comments Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit d265fc7)
* Adds create connector API for MLClient Signed-off-by: Owais Kazi <[email protected]> * Addressed PR comments Signed-off-by: Owais Kazi <[email protected]> * Addressed PR Comments Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit d265fc7) Co-authored-by: Owais Kazi <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-feature/agent_framework_dev feature/agent_framework_dev
# Navigate to the new working tree
cd .worktrees/backport-feature/agent_framework_dev
# Create a new branch
git switch --create backport/backport-1437-to-feature/agent_framework_dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d265fc7f48b4b17f969b9a589ccde4f5ffd9891e
# Push it to GitHub
git push --set-upstream origin backport/backport-1437-to-feature/agent_framework_dev
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-feature/agent_framework_dev Then, create a pull request where the |
Signed-off-by: Joshua Palis <[email protected]>
* Manual Backport of #1388 Signed-off-by: Joshua Palis <[email protected]> * Manual backport of #1437 Signed-off-by: Joshua Palis <[email protected]> * Manual backport of 1493 Signed-off-by: Joshua Palis <[email protected]> * Manual backport of 1560 Signed-off-by: Joshua Palis <[email protected]> * manual backport of 1580 Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]>
* Adds create connector API for MLClient Signed-off-by: Owais Kazi <[email protected]> * Addressed PR comments Signed-off-by: Owais Kazi <[email protected]> * Addressed PR Comments Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: TrungBui59 <[email protected]>
Description
Added create connector API for MLClient.
Issues Resolved
Part of opensearch-project/flow-framework#70
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.