Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added create connector API for MLClient #1437

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Oct 4, 2023

Description

Added create connector API for MLClient.

Issues Resolved

Part of opensearch-project/flow-framework#70

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 4, 2023 23:38 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 4, 2023 23:38 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 4, 2023 23:38 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 4, 2023 23:38 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 4, 2023 23:38 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 4, 2023 23:38 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1437 (26422bb) into main (374b835) will decrease coverage by 0.01%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1437      +/-   ##
============================================
- Coverage     78.25%   78.24%   -0.01%     
  Complexity     2308     2308              
============================================
  Files           193      193              
  Lines          9449     9455       +6     
  Branches        942      942              
============================================
+ Hits           7394     7398       +4     
- Misses         1631     1634       +3     
+ Partials        424      423       -1     
Flag Coverage Δ
ml-commons 78.24% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rg/opensearch/ml/client/MachineLearningClient.java 100.00% <100.00%> (ø)
...pensearch/ml/client/MachineLearningNodeClient.java 93.04% <100.00%> (+0.18%) ⬆️

... and 2 files with indirect coverage changes

Signed-off-by: Owais Kazi <[email protected]>
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 5, 2023 17:58 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 5, 2023 17:58 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 5, 2023 17:58 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 5, 2023 17:58 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 9, 2023 21:52 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 9, 2023 21:52 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 9, 2023 21:52 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 9, 2023 23:49 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 9, 2023 23:49 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 9, 2023 23:49 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 9, 2023 23:49 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 10, 2023 00:46 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 10, 2023 00:46 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 10, 2023 00:46 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 10, 2023 00:46 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env October 10, 2023 00:46 — with GitHub Actions Inactive
@owaiskazi19
Copy link
Member Author

@ylwu-amzn @jngz-es can I get another review on this one? Thanks

@dhrubo-os dhrubo-os merged commit d265fc7 into opensearch-project:main Oct 12, 2023
8 of 10 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1437-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d265fc7f48b4b17f969b9a589ccde4f5ffd9891e
# Push it to GitHub
git push --set-upstream origin backport/backport-1437-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1437-to-2.x.

@dhrubo-os
Copy link
Collaborator

@owaiskazi19 could you also please raise a backport PR for 2.x branch? Thanks.

@owaiskazi19
Copy link
Member Author

@owaiskazi19 could you also please raise a backport PR for 2.x branch? Thanks.

@dhrubo-os this needs to be merged before backporting this.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2023
* Adds create connector API for MLClient

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR comments

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR Comments

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit d265fc7)
dhrubo-os pushed a commit that referenced this pull request Oct 12, 2023
* Adds create connector API for MLClient

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR comments

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR Comments

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit d265fc7)

Co-authored-by: Owais Kazi <[email protected]>
@opensearch-trigger-bot
Copy link
Contributor

The backport to feature/agent_framework_dev failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-feature/agent_framework_dev feature/agent_framework_dev
# Navigate to the new working tree
cd .worktrees/backport-feature/agent_framework_dev
# Create a new branch
git switch --create backport/backport-1437-to-feature/agent_framework_dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d265fc7f48b4b17f969b9a589ccde4f5ffd9891e
# Push it to GitHub
git push --set-upstream origin backport/backport-1437-to-feature/agent_framework_dev
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-feature/agent_framework_dev

Then, create a pull request where the base branch is feature/agent_framework_dev and the compare/head branch is backport/backport-1437-to-feature/agent_framework_dev.

joshpalis added a commit to joshpalis/ml-commons that referenced this pull request Nov 3, 2023
dhrubo-os pushed a commit that referenced this pull request Nov 3, 2023
* Manual Backport of #1388

Signed-off-by: Joshua Palis <[email protected]>

* Manual backport of #1437

Signed-off-by: Joshua Palis <[email protected]>

* Manual backport of 1493

Signed-off-by: Joshua Palis <[email protected]>

* Manual backport of 1560

Signed-off-by: Joshua Palis <[email protected]>

* manual backport of 1580

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 21, 2023
* Adds create connector API for MLClient

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR comments

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR Comments

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants