Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Add support for context_size and include 'interaction_id' in SearchRe… #1433

Conversation

HenryL27
Copy link
Collaborator

@HenryL27 HenryL27 commented Oct 4, 2023

…… (#1385)


(cherry picked from commit ae6995a)

Description

PR 4/4 to bring conversational features to main

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-project#1385)

* Add support for context_size and include 'interaction_id' in SearchResponse. [Issue opensearch-project#1372]

Signed-off-by: Austin Lee <[email protected]>

* Added spotless, removed unused code, added more comments.

Signed-off-by: Austin Lee <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit ae6995a)
Signed-off-by: HenryL27 <[email protected]>
@HenryL27 HenryL27 temporarily deployed to ml-commons-cicd-env October 4, 2023 20:55 — with GitHub Actions Inactive
@HenryL27 HenryL27 temporarily deployed to ml-commons-cicd-env October 4, 2023 20:55 — with GitHub Actions Inactive
@HenryL27 HenryL27 had a problem deploying to ml-commons-cicd-env October 4, 2023 20:55 — with GitHub Actions Failure
@HenryL27 HenryL27 had a problem deploying to ml-commons-cicd-env October 4, 2023 20:55 — with GitHub Actions Failure
@jngz-es jngz-es merged commit 374b835 into opensearch-project:main Oct 4, 2023
5 of 9 checks passed
TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 21, 2023
opensearch-project#1385) (opensearch-project#1433)

* Add support for context_size and include 'interaction_id' in SearchResponse. [Issue opensearch-project#1372]

* Added spotless, removed unused code, added more comments.

---------

(cherry picked from commit ae6995a)

Signed-off-by: Austin Lee <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Co-authored-by: Austin Lee <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants