Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 2.x] fix more places where thread context not restored (#1421) #1423

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Backport PR #1421 to 2.x

…#1421)

* fix more places where thread context not restored

Signed-off-by: Yaliang Wu <[email protected]>

* fix failed ut

Signed-off-by: Yaliang Wu <[email protected]>

* remove unused import

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 3, 2023 18:18 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 3, 2023 18:18 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 3, 2023 18:18 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 3, 2023 18:18 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1423 (7b2db1e) into 2.x (c45555c) will increase coverage by 0.00%.
Report is 1 commits behind head on 2.x.
The diff coverage is 74.82%.

@@            Coverage Diff            @@
##                2.x    #1423   +/-   ##
=========================================
  Coverage     78.23%   78.23%           
- Complexity     2305     2324   +19     
=========================================
  Files           195      195           
  Lines          9377     9397   +20     
  Branches        920      920           
=========================================
+ Hits           7336     7352   +16     
- Misses         1626     1631    +5     
+ Partials        415      414    -1     
Flag Coverage Δ
ml-commons 78.23% <74.82%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../opensearch/ml/engine/encryptor/EncryptorImpl.java 91.04% <100.00%> (ø)
...tion/connector/DeleteConnectorTransportAction.java 94.91% <100.00%> (+0.08%) ⬆️
...tion/connector/SearchConnectorTransportAction.java 100.00% <100.00%> (ø)
...n/model_group/SearchModelGroupTransportAction.java 100.00% <100.00%> (ø)
...search/ml/action/tasks/GetTaskTransportAction.java 62.50% <100.00%> (ø)
...rch/ml/action/tasks/SearchTaskTransportAction.java 72.72% <100.00%> (ø)
...action/undeploy/TransportUndeployModelsAction.java 94.00% <100.00%> (ø)
...a/org/opensearch/ml/model/MLModelGroupManager.java 83.76% <100.00%> (+0.13%) ⬆️
.../opensearch/ml/action/handler/MLSearchHandler.java 87.36% <83.33%> (+0.13%) ⬆️
...n/model_group/DeleteModelGroupTransportAction.java 92.68% <85.71%> (+0.18%) ⬆️
... and 9 more

... and 2 files with indirect coverage changes

@ylwu-amzn ylwu-amzn merged commit d8c1162 into opensearch-project:2.x Oct 3, 2023
7 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2023
* fix more places where thread context not restored

* fix failed ut

* remove unused import

---------

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit d8c1162)
dhrubo-os pushed a commit that referenced this pull request Oct 5, 2023
)

* fix more places where thread context not restored

* fix failed ut

* remove unused import

---------

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit d8c1162)

Co-authored-by: Yaliang Wu <[email protected]>
TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 21, 2023
…#1421) (opensearch-project#1423) (opensearch-project#1436)

* fix more places where thread context not restored

* fix failed ut

* remove unused import

---------

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit d8c1162)

Co-authored-by: Yaliang Wu <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants