Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for context_size and include 'interaction_id' in SearchRe… #1385

Merged
merged 2 commits into from
Oct 3, 2023

Added spotless, removed unused code, added more comments.

857f436
Select commit
Loading
Failed to load commit list.
Merged

Add support for context_size and include 'interaction_id' in SearchRe… #1385

Added spotless, removed unused code, added more comments.
857f436
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Oct 2, 2023 in 0s

78.49% (target 80.00%)

View this Pull Request on Codecov

78.49% (target 80.00%)

Details

Codecov Report

Merging #1385 (857f436) into 2.x (2c8cc02) will increase coverage by 0.14%.
Report is 9 commits behind head on 2.x.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##                2.x    #1385      +/-   ##
============================================
+ Coverage     78.35%   78.49%   +0.14%     
- Complexity     2275     2296      +21     
============================================
  Files           190      190              
  Lines          9286     9418     +132     
  Branches        910      934      +24     
============================================
+ Hits           7276     7393     +117     
- Misses         1599     1602       +3     
- Partials        411      423      +12     
Files Coverage Δ
...ing/generative/GenerativeQAProcessorConstants.java 75.00% <ø> (ø)
...ering/generative/GenerativeQARequestProcessor.java 100.00% <100.00%> (ø)
.../generative/client/ConversationalMemoryClient.java 97.22% <100.00%> (+0.34%) ⬆️
...ng/generative/ext/GenerativeQAParamExtBuilder.java 100.00% <ø> (ø)
...nswering/generative/ext/GenerativeQAParamUtil.java 92.85% <100.00%> (+3.96%) ⬆️
...nanswering/generative/llm/ChatCompletionInput.java 100.00% <ø> (ø)
...estionanswering/generative/llm/DefaultLlmImpl.java 100.00% <100.00%> (ø)
...es/questionanswering/generative/llm/LlmIOUtil.java 100.00% <100.00%> (ø)
...questionanswering/generative/llm/ModelLocator.java 100.00% <ø> (ø)
...answering/generative/GenerativeSearchResponse.java 94.73% <87.50%> (-5.27%) ⬇️
... and 5 more