fix system index access bug #1272 #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HenryL27 <[email protected]>
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
|
Only failing test was Remote Cohere. I have confirmed locally that this fix does indeed work |
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
approved these changes
Sep 12, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1320 +/- ##
============================================
- Coverage 79.28% 79.24% -0.04%
+ Complexity 2250 2247 -3
============================================
Files 188 188
Lines 9089 9089
Branches 904 904
============================================
- Hits 7206 7203 -3
- Misses 1473 1478 +5
+ Partials 410 408 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Sep 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Signed-off-by: HenryL27 <[email protected]> (cherry picked from commit 8cdac91)
dhrubo-os
pushed a commit
that referenced
this pull request
Sep 12, 2023
Signed-off-by: HenryL27 <[email protected]> (cherry picked from commit 8cdac91) Co-authored-by: HenryL27 <[email protected]>
HenryL27
added a commit
to HenryL27/ml-commons
that referenced
this pull request
Oct 3, 2023
…ct#1320) Signed-off-by: HenryL27 <[email protected]>
HenryL27
added a commit
to HenryL27/ml-commons
that referenced
this pull request
Oct 3, 2023
…ct#1320) Signed-off-by: HenryL27 <[email protected]> (cherry picked from commit 8cdac91) Signed-off-by: HenryL27 <[email protected]>
HenryL27
added a commit
to HenryL27/ml-commons
that referenced
this pull request
Oct 4, 2023
…ct#1320) Signed-off-by: HenryL27 <[email protected]> (cherry picked from commit 8cdac91) Signed-off-by: HenryL27 <[email protected]>
dhrubo-os
pushed a commit
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit 8cdac91) Signed-off-by: HenryL27 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
newStoredContext() -> stashContext() for system index ops
Issues Resolved
#1272
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.