Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.10] Fix unassigned ml system shard replicas #1316

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 56976e1 from #1315

* Fix unassigned ml system shard replicas

Signed-off-by: Sicheng Song <[email protected]>

* Adjust auto replica settings to keep it consistent with AOS default setting

Signed-off-by: Sicheng Song <[email protected]>

* Update plugin/src/main/java/org/opensearch/ml/indices/MLIndicesHandler.java

Co-authored-by: Yaliang Wu <[email protected]>
Signed-off-by: Sicheng Song <[email protected]>

* Modify exception handling

Signed-off-by: Sicheng Song <[email protected]>

* Modify exception messages

Signed-off-by: Sicheng Song <[email protected]>

* Add response check

Signed-off-by: Sicheng Song <[email protected]>

* Add response check and exception handling

Signed-off-by: Sicheng Song <[email protected]>

* Keep error message consistent

Signed-off-by: Sicheng Song <[email protected]>

* Keep error message consistent

Signed-off-by: Sicheng Song <[email protected]>

* Keep error message consistent

Signed-off-by: Sicheng Song <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
(cherry picked from commit 56976e1)
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env September 9, 2023 04:45 Inactive
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env September 9, 2023 04:45 Inactive
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env September 9, 2023 04:45 Inactive
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env September 9, 2023 04:45 Inactive
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #1316 (1eefb85) into 2.10 (9c2fbac) will decrease coverage by 0.16%.
Report is 2 commits behind head on 2.10.
The diff coverage is 21.05%.

@@             Coverage Diff              @@
##               2.10    #1316      +/-   ##
============================================
- Coverage     79.40%   79.24%   -0.16%     
  Complexity     2247     2247              
============================================
  Files           188      188              
  Lines          9074     9089      +15     
  Branches        903      904       +1     
============================================
- Hits           7205     7203       -2     
- Misses         1461     1478      +17     
  Partials        408      408              
Flag Coverage Δ
ml-commons 79.24% <21.05%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...va/org/opensearch/ml/indices/MLIndicesHandler.java 59.34% <21.05%> (-10.40%) ⬇️

... and 1 file with indirect coverage changes

@b4sjoo b4sjoo merged commit e360727 into 2.10 Sep 12, 2023
@b4sjoo b4sjoo deleted the backport/backport-1315-to-2.10 branch September 12, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants