[Backport 2.x] fixing metrics #1198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* fixing metrics Signed-off-by: Dhrubo Saha <[email protected]> * addressing comments Signed-off-by: Dhrubo Saha <[email protected]> * addressing comments Signed-off-by: Dhrubo Saha <[email protected]> * updating test Signed-off-by: Dhrubo Saha <[email protected]> * added IllegalArgumentException in the if statement Signed-off-by: Dhrubo Saha <[email protected]> * addressing comments Signed-off-by: Dhrubo Saha <[email protected]> * fixing spotless Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit deb0008)
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
Codecov Report
@@ Coverage Diff @@
## 2.x #1198 +/- ##
============================================
- Coverage 78.91% 78.90% -0.02%
- Complexity 2120 2122 +2
============================================
Files 167 167
Lines 8641 8646 +5
Branches 870 870
============================================
+ Hits 6819 6822 +3
Misses 1428 1428
- Partials 394 396 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
ylwu-amzn
approved these changes
Aug 16, 2023
|
closing this in favor of : #1220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport deb0008 from #1194