Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix breaking changes from opensearch core #1182

Closed
wants to merge 2 commits into from
Closed

fix breaking changes from opensearch core #1182

wants to merge 2 commits into from

Conversation

ylwu-amzn
Copy link
Collaborator

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 3, 2023 01:12 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 3, 2023 01:12 — with GitHub Actions Failure
@ylwu-amzn
fix TransportAddress
ed4eb32 
Signed-off-by: Yaliang Wu <[email protected]>
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 3, 2023 01:22 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 3, 2023 01:22 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 3, 2023 01:22 — with GitHub Actions Failure
@ylwu-amzn
Copy link
Collaborator Author

Don't review this PR now, find more breaking changes.

@ylwu-amzn ylwu-amzn marked this pull request as draft August 3, 2023 01:31
@martin-gaievski martin-gaievski mentioned this pull request Aug 3, 2023
Closed
@saratvemulapalli saratvemulapalli mentioned this pull request Aug 7, 2023
Closed
5 tasks
@saratvemulapalli
Copy link
Member

I didnt realize there are multiple PRs already trying to fix the build, I was chasing a bug #1179 and ended up with compile problems.
Feel free to use changes from this PR: #1189

@ylwu-amzn
Copy link
Collaborator Author

I didnt realize there are multiple PRs already trying to fix the build, I was chasing a bug #1179 and ended up with compile problems. Feel free to use changes from this PR: #1189

Thanks Sarat, I will close this draft PR.

@ylwu-amzn ylwu-amzn closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo will be requested when the pull request is marked ready for review b4sjoo is a code owner

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os will be requested when the pull request is marked ready for review dhrubo-os is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es will be requested when the pull request is marked ready for review jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse will be requested when the pull request is marked ready for review model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna will be requested when the pull request is marked ready for review rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo will be requested when the pull request is marked ready for review zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt will be requested when the pull request is marked ready for review Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee will be requested when the pull request is marked ready for review austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 will be requested when the pull request is marked ready for review HenryL27 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ylwu-amzn @saratvemulapalli