Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 2.x]add more stats: connector count, connector/config index status; fix model count bug #1181

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Description

Backport #1180 to 2.x

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 3, 2023 01:00 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 3, 2023 01:00 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn marked this pull request as draft August 3, 2023 01:03
dhrubo-os
dhrubo-os previously approved these changes Aug 3, 2023
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 15, 2023 04:43 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 15, 2023 04:43 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 15, 2023 04:43 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 15, 2023 06:09 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 15, 2023 06:09 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 15, 2023 06:09 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 15, 2023 06:09 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1181 (f3995d8) into 2.x (5c2dc5d) will decrease coverage by 0.10%.
The diff coverage is 53.06%.

@@             Coverage Diff              @@
##                2.x    #1181      +/-   ##
============================================
- Coverage     78.84%   78.74%   -0.10%     
- Complexity     2118     2121       +3     
============================================
  Files           167      167              
  Lines          8641     8676      +35     
  Branches        870      870              
============================================
+ Hits           6813     6832      +19     
- Misses         1432     1450      +18     
+ Partials        396      394       -2     
Flag Coverage Δ
ml-commons 78.74% <53.06%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...va/org/opensearch/ml/engine/utils/ScriptUtils.java 76.47% <ø> (ø)
...a/org/opensearch/ml/model/MLModelGroupManager.java 84.48% <ø> (ø)
.../main/java/org/opensearch/ml/utils/IndexUtils.java 41.17% <0.00%> (-22.46%) ⬇️
.../opensearch/ml/engine/encryptor/EncryptorImpl.java 91.04% <66.66%> (ø)
...java/org/opensearch/ml/rest/RestMLStatsAction.java 91.66% <78.94%> (-3.24%) ⬇️
...rg/opensearch/ml/plugin/MachineLearningPlugin.java 99.04% <100.00%> (+0.03%) ⬆️
...va/org/opensearch/ml/stats/MLClusterLevelStat.java 80.00% <100.00%> (+8.57%) ⬆️

... and 2 files with indirect coverage changes

@ylwu-amzn ylwu-amzn marked this pull request as ready for review August 15, 2023 19:56
b4sjoo
b4sjoo previously approved these changes Aug 15, 2023
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 16, 2023 00:10 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 00:10 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 16, 2023 00:10 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 00:31 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 00:31 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 16, 2023 00:31 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 01:32 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 01:32 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 01:32 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 02:09 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 02:09 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 02:09 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 02:09 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit 89dab70 into opensearch-project:2.x Aug 16, 2023
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Sep 1, 2023
zane-neo pushed a commit that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants