add remote inference tutorial #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov Report
@@ Coverage Diff @@
## 2.x #1158 +/- ##
============================================
- Coverage 78.99% 78.94% -0.06%
+ Complexity 2121 2118 -3
============================================
Files 167 167
Lines 8633 8633
Branches 869 869
============================================
- Hits 6820 6815 -5
- Misses 1419 1425 +6
+ Partials 394 393 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
b4sjoo
approved these changes
Jul 26, 2023
Zhangxunmt
approved these changes
Jul 26, 2023
| In 2.9, we released [ML model access control](https://opensearch.org/docs/latest/ml-commons-plugin/model-access-control/) which supports model level access control. | ||
| User can enable the feature by | ||
| ``` | ||
| PUT /_cluster/settings |
There was a problem hiding this comment.
should we add some explain for the case when model_access_control is disabled? Since we support default model group, so this setting is not required to be true anymore. We should let user know that the feature still works without the access control but it would introduce risks, etc.
| PUT /_cluster/settings | ||
| { | ||
| "persistent" : { | ||
| "plugins.ml_commons.connector_access_control_enabled" : true |
There was a problem hiding this comment.
The same to the model access control, we can add a little bit description that the setting can be false and the feature will still work without access control.
| "parameters": { | ||
| "model": "gpt-3.5-turbo" | ||
| }, | ||
| "credential": { |
There was a problem hiding this comment.
We should state that this credential provided to Ml-commons will not be shown to the customer through any APIs, so it's customers' responsibility to store the credential safely.
There was a problem hiding this comment.
Thanks, will address the comments in a new PR soon.
zane-neo
pushed a commit
to zane-neo/ml-commons
that referenced
this pull request
Sep 1, 2023
* add remote inference tutorial Signed-off-by: Yaliang Wu <[email protected]> * change model group id to keep consistent Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]>
zane-neo
pushed a commit
that referenced
this pull request
Sep 1, 2023
* add remote inference tutorial Signed-off-by: Yaliang Wu <[email protected]> * change model group id to keep consistent Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.