-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix core package name to address compilation errors #1122
Fix core package name to address compilation errors #1122
Conversation
424b311
to
497fe7d
Compare
Signed-off-by: Martin Gaievski <[email protected]>
497fe7d
to
b7e561f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1122 +/- ##
=========================================
Coverage 84.12% 84.12%
Complexity 1755 1755
=========================================
Files 139 139
Lines 6716 6716
Branches 669 669
=========================================
Hits 5650 5650
Misses 769 769
Partials 297 297
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Could you please backport this to 2.x? The core refactor was backported yesterday -- opensearch-project/OpenSearch#8782 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1122-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6bfc1d3a64e225ede879bd9c47527c474b25a8d3
# Push it to GitHub
git push --set-upstream origin backport/backport-1122-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
I'm working on backporting this change to 2.x. PR will be up shortly. |
…ct#1122) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 6bfc1d3)
…ct#1122) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 6bfc1d3)
…ct#1122) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 6bfc1d3)
…1157) * Fix core package name to address compilation errors (#1122) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 6bfc1d3) * Empty commit to trigger PR checks. Signed-off-by: Max Ksyunz <[email protected]> --------- Signed-off-by: Max Ksyunz <[email protected]> Co-authored-by: Martin Gaievski <[email protected]>
Description
Fix compilation errors after code refactoring PR. Core PR is marked with "backport 2.x", so similar change may be required in 2.x branch as well.
In this PR it's only changing package name of core classes in import section
Noticed in scope of fixing same for neural-search: opensearch-project/neural-search#219
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.