create model group automatically with first model version #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
reviewed
Jul 10, 2023
| public static final String MODEL_FORMAT_FIELD = "model_format"; //mandatory | ||
| public static final String MODEL_STATE_FIELD = "model_state"; | ||
| public static final String MODEL_CONTENT_SIZE_IN_BYTES_FIELD = "model_content_size_in_bytes"; | ||
| public static final String MODEL_CONTENT_HASH_VALUE_FIELD = "model_content_hash_value"; //mandatory | ||
| public static final String MODEL_CONFIG_FIELD = "model_config"; //mandatory | ||
| public static final String TOTAL_CHUNKS_FIELD = "total_chunks"; //mandatory | ||
| public static final String MODEL_GROUP_ID_FIELD = "model_group_id"; //mandatory | ||
| public static final String MODEL_GROUP_ID_FIELD = "model_group_id"; //optional | ||
| public static final String BACKEND_ROLES_FIELD = "backend_roles"; //optional |
There was a problem hiding this comment.
I see all access control fields are optional now. Per my understanding, if user doesn't provide any of these, the model group will be private, right?
There was a problem hiding this comment.
yes. It will be created as private
ylwu-amzn
previously approved these changes
Jul 10, 2023
Signed-off-by: Bhavana Ramaram <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>
rbhavna
force-pushed
the
model_access_control_to_2.x
branch
from
f6d5764 to
4f49ec1
Compare
Signed-off-by: Bhavana Ramaram <[email protected]>
ylwu-amzn
approved these changes
Jul 10, 2023
dhrubo-os
approved these changes
Jul 10, 2023
zane-neo
pushed a commit
to zane-neo/ml-commons
that referenced
this pull request
Sep 1, 2023
…-project#1063) * create model group automatically with first model version Signed-off-by: Bhavana Ramaram <[email protected]>
zane-neo
pushed a commit
that referenced
this pull request
Sep 1, 2023
* create model group automatically with first model version Signed-off-by: Bhavana Ramaram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
create model group automatically with first model version
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.