change to compileOnly to avoid jarhell #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
dhrubo-os
previously approved these changes
Jul 10, 2023
rbhavna
previously approved these changes
Jul 10, 2023
Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Yaliang Wu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #1062 +/- ##
============================================
+ Coverage 77.76% 77.79% +0.02%
Complexity 2021 2021
============================================
Files 162 162
Lines 8353 8353
Branches 836 836
============================================
+ Hits 6496 6498 +2
+ Misses 1483 1482 -1
+ Partials 374 373 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
dhrubo-os
approved these changes
Jul 10, 2023
rbhavna
approved these changes
Jul 10, 2023
zane-neo
pushed a commit
to zane-neo/ml-commons
that referenced
this pull request
Sep 1, 2023
* change to compileOnly to avoid jarhell Signed-off-by: Yaliang Wu <[email protected]> * fix missing class Signed-off-by: Yaliang Wu <[email protected]> * add json dependency to ml-algorithms Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]>
zane-neo
pushed a commit
that referenced
this pull request
Sep 1, 2023
* change to compileOnly to avoid jarhell Signed-off-by: Yaliang Wu <[email protected]> * fix missing class Signed-off-by: Yaliang Wu <[email protected]> * add json dependency to ml-algorithms Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.