Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor predictable: add method to check if model is ready #1057

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn marked this pull request as ready for review July 9, 2023 20:20
Signed-off-by: Yaliang Wu <[email protected]>
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #1057 (c30752a) into 2.x (e2c9948) will increase coverage by 0.13%.
The diff coverage is 41.02%.

@@             Coverage Diff              @@
##                2.x    #1057      +/-   ##
============================================
+ Coverage     78.40%   78.54%   +0.13%     
- Complexity     1928     1944      +16     
============================================
  Files           157      157              
  Lines          7934     7960      +26     
  Branches        796      797       +1     
============================================
+ Hits           6221     6252      +31     
+ Misses         1357     1353       -4     
+ Partials        356      355       -1     
Flag Coverage Δ
ml-commons 78.54% <41.02%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/org/opensearch/ml/engine/algorithms/DLModel.java 82.69% <0.00%> (-1.63%) ⬇️
...l/engine/algorithms/ad/AnomalyDetectionLibSVM.java 85.71% <0.00%> (-1.13%) ⬇️
...search/ml/engine/algorithms/clustering/KMeans.java 90.47% <0.00%> (-1.46%) ⬇️
.../ml/engine/algorithms/clustering/RCFSummarize.java 82.02% <0.00%> (-0.94%) ⬇️
...ml/engine/algorithms/rcf/BatchRandomCutForest.java 88.00% <0.00%> (-1.19%) ⬇️
...ine/algorithms/rcf/FixedInTimeRandomCutForest.java 84.61% <0.00%> (-0.83%) ⬇️
...engine/algorithms/regression/LinearRegression.java 90.90% <0.00%> (-0.93%) ⬇️
...gine/algorithms/regression/LogisticRegression.java 79.06% <0.00%> (-0.94%) ⬇️
...search/ml/engine/algorithms/sample/SampleAlgo.java 80.00% <0.00%> (-3.34%) ⬇️
...va/org/opensearch/ml/task/MLPredictTaskRunner.java 80.82% <12.50%> (-1.58%) ⬇️
... and 1 more

... and 4 files with indirect coverage changes

@ylwu-amzn ylwu-amzn merged commit c989d61 into opensearch-project:2.x Jul 9, 2023
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Sep 1, 2023
…ch-project#1057)

* refactor predictable: add method to check if model is ready

Signed-off-by: Yaliang Wu <[email protected]>

* fix failed ut

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
zane-neo pushed a commit that referenced this pull request Sep 1, 2023
* refactor predictable: add method to check if model is ready

Signed-off-by: Yaliang Wu <[email protected]>

* fix failed ut

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants