-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Adding an integration test for redeploying a model #1016
Merged
ylwu-amzn
merged 13 commits into
opensearch-project:2.x
from
saratvemulapalli:redeploy-model-test
Jul 5, 2023
Merged
[2.x] Adding an integration test for redeploying a model #1016
ylwu-amzn
merged 13 commits into
opensearch-project:2.x
from
saratvemulapalli:redeploy-model-test
Jul 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es from OpenSearch core Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Hi @saratvemulapalli you might need to resolve the conflict lies in |
…es from OpenSearch core Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #1016 +/- ##
============================================
+ Coverage 82.29% 82.32% +0.02%
Complexity 1918 1918
============================================
Files 149 149
Lines 7506 7506
Branches 750 750
============================================
+ Hits 6177 6179 +2
+ Misses 988 987 -1
+ Partials 341 340 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
saratvemulapalli
changed the title
[2.x] Adding a failing test for redeploy model
[2.x] Adding an integration test for redeploying a model
Jun 29, 2023
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
dhrubo-os
approved these changes
Jun 30, 2023
b4sjoo
approved these changes
Jun 30, 2023
zane-neo
pushed a commit
to zane-neo/ml-commons
that referenced
this pull request
Aug 29, 2023
…project#1016) * Adding a failing integ test for redeploy model and fix breaking changes from OpenSearch core Signed-off-by: Sarat Vemulapalli <[email protected]> * Adding model group ID changes for tests Signed-off-by: Sarat Vemulapalli <[email protected]> * Fixing tests for ImmutableMap copy Signed-off-by: Sarat Vemulapalli <[email protected]> * Commenting wait out task for model Signed-off-by: Sarat Vemulapalli <[email protected]> * Adding a failing integ test for redeploy model and fix breaking changes from OpenSearch core Signed-off-by: Sarat Vemulapalli <[email protected]> * Rebasing with 2.x Signed-off-by: Sarat Vemulapalli <[email protected]> * Adding logs to debug the test in GHA Signed-off-by: Sarat Vemulapalli <[email protected]> * GHA tests Signed-off-by: Sarat Vemulapalli <[email protected]> * Still debugging Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing comment Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing unnecessary changes Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing logs Signed-off-by: Sarat Vemulapalli <[email protected]> --------- Signed-off-by: Sarat Vemulapalli <[email protected]>
5 tasks
zane-neo
added a commit
that referenced
this pull request
Aug 30, 2023
* Adding a failing integ test for redeploy model and fix breaking changes from OpenSearch core * Adding model group ID changes for tests * Fixing tests for ImmutableMap copy * Commenting wait out task for model * Adding a failing integ test for redeploy model and fix breaking changes from OpenSearch core * Rebasing with 2.x * Adding logs to debug the test in GHA * GHA tests * Still debugging * Removing comment * Removing unnecessary changes * Removing logs --------- Signed-off-by: Sarat Vemulapalli <[email protected]> Co-authored-by: Sarat Vemulapalli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-Deploying a model fails due to bug #844.This bug only shows up on MacOS, but works on Linux/WindowsIssues Resolved
#844
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.