Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Adding an integration test for redeploying a model #1016

Merged
merged 13 commits into from
Jul 5, 2023
Merged

[2.x] Adding an integration test for redeploying a model #1016

merged 13 commits into from
Jul 5, 2023

Conversation

saratvemulapalli
Copy link
Member

@saratvemulapalli saratvemulapalli commented Jun 26, 2023

Description

Re-Deploying a model fails due to bug #844. This bug only shows up on MacOS, but works on Linux/Windows

Issues Resolved

#844

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…es from OpenSearch core

Signed-off-by: Sarat Vemulapalli <[email protected]>
@saratvemulapalli saratvemulapalli mentioned this pull request Jun 27, 2023
5 tasks
@b4sjoo
Copy link
Collaborator

b4sjoo commented Jun 29, 2023

Hi @saratvemulapalli you might need to resolve the conflict lies in AnomalyLocalizerImplTests.java

…es from OpenSearch core

Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #1016 (eaaf6e5) into 2.x (43d1b1a) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #1016      +/-   ##
============================================
+ Coverage     82.29%   82.32%   +0.02%     
  Complexity     1918     1918              
============================================
  Files           149      149              
  Lines          7506     7506              
  Branches        750      750              
============================================
+ Hits           6177     6179       +2     
+ Misses          988      987       -1     
+ Partials        341      340       -1     
Flag Coverage Δ
ml-commons 82.32% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@saratvemulapalli saratvemulapalli changed the title [2.x] Adding a failing test for redeploy model [2.x] Adding an integration test for redeploying a model Jun 29, 2023
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
@ylwu-amzn ylwu-amzn merged commit 103a401 into opensearch-project:2.x Jul 5, 2023
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Aug 29, 2023
…project#1016)

* Adding a failing integ test for redeploy model and fix breaking changes from OpenSearch core

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Adding model group ID changes for tests

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Fixing tests for ImmutableMap copy

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Commenting wait out task for model

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Adding a failing integ test for redeploy model and fix breaking changes from OpenSearch core

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Rebasing with 2.x

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Adding logs to debug the test in GHA

Signed-off-by: Sarat Vemulapalli <[email protected]>

* GHA tests

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Still debugging

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Removing comment

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Removing unnecessary changes

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Removing logs

Signed-off-by: Sarat Vemulapalli <[email protected]>

---------

Signed-off-by: Sarat Vemulapalli <[email protected]>
@saratvemulapalli saratvemulapalli deleted the redeploy-model-test branch August 29, 2023 18:28
zane-neo added a commit that referenced this pull request Aug 30, 2023
* Adding a failing integ test for redeploy model and fix breaking changes from OpenSearch core



* Adding model group ID changes for tests



* Fixing tests for ImmutableMap copy



* Commenting wait out task for model



* Adding a failing integ test for redeploy model and fix breaking changes from OpenSearch core



* Rebasing with 2.x



* Adding logs to debug the test in GHA



* GHA tests



* Still debugging



* Removing comment



* Removing unnecessary changes



* Removing logs



---------

Signed-off-by: Sarat Vemulapalli <[email protected]>
Co-authored-by: Sarat Vemulapalli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants