Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Add support for SageMaker Bedrock to the RAG pipeline by supporting single string prompts #1476

Closed
austintlee opened this issue Oct 10, 2023 · 3 comments
Closed

[BUG] Add support for SageMaker Bedrock to the RAG pipeline by supporting single string prompts #1476

austintlee opened this issue Oct 10, 2023 · 3 comments
Labels
enhancement New feature or request untriaged

Comments

@austintlee
Copy link
Collaborator

Is your feature request related to a problem?
The RAG pipeline does not know how to pass "inputs" and return "completion" from Bedrock's Anthropic model.

What solution would you like?
As a special case of #1475, we could introduce a connector_type that would initially accept openai/chat and aws/bedrock and support inputs and outputs for those endpoints.

In addition, we can have a mode where we just return the entire dataAsMap and leave the parsing to the calling application.

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.
@austintlee austintlee added enhancement New feature or request untriaged labels Oct 10, 2023
@austintlee
Copy link
Collaborator Author

@zane-neo @dhrubo-os @jngz-es I would love to get your take on this. There is a re:invent workshop where we want to show this working with Bedrock.

cc: @ylwu-amzn @HenryL27

@austintlee austintlee changed the title [FEATURE] Add support for SageMaker Bedrock to the RAG pipeline [BUG] Add support for SageMaker Bedrock to the RAG pipeline by supporting single string prompts Oct 11, 2023
austintlee added a commit to austintlee/ml-commons that referenced this issue Oct 11, 2023
@austintlee
Fix prompt passing for Bedrock by passing a single string prompt for …
91582da 
…Bedrock models. (opensearch-project#1476)

Signed-off-by: Austin Lee <[email protected]>
@austintlee austintlee mentioned this issue Oct 11, 2023
Merged
2 tasks
dhrubo-os pushed a commit that referenced this issue Oct 11, 2023
@austintlee
Fix prompt passing for Bedrock by passing a single string prompt for … (
e18f249 
#1490)

* Fix prompt passing for Bedrock by passing a single string prompt for Bedrock models. (#1476)

Signed-off-by: Austin Lee <[email protected]>

* Add unit tests, apply Spotless.

Signed-off-by: Austin Lee <[email protected]>

* Check if systemPrompt is null.

Signed-off-by: Austin Lee <[email protected]>

* Address review comments.

Signed-off-by: Austin Lee <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 11, 2023
@austintlee @github-actions
Fix prompt passing for Bedrock by passing a single string prompt for … (
7878baa 
#1490)

* Fix prompt passing for Bedrock by passing a single string prompt for Bedrock models. (#1476)

Signed-off-by: Austin Lee <[email protected]>

* Add unit tests, apply Spotless.

Signed-off-by: Austin Lee <[email protected]>

* Check if systemPrompt is null.

Signed-off-by: Austin Lee <[email protected]>

* Address review comments.

Signed-off-by: Austin Lee <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit e18f249)
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 11, 2023
@austintlee @github-actions
Fix prompt passing for Bedrock by passing a single string prompt for … (
47f1089 
#1490)

* Fix prompt passing for Bedrock by passing a single string prompt for Bedrock models. (#1476)

Signed-off-by: Austin Lee <[email protected]>

* Add unit tests, apply Spotless.

Signed-off-by: Austin Lee <[email protected]>

* Check if systemPrompt is null.

Signed-off-by: Austin Lee <[email protected]>

* Address review comments.

Signed-off-by: Austin Lee <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit e18f249)
dhrubo-os pushed a commit that referenced this issue Oct 11, 2023
@opensearch-trigger-bot @austintlee
Fix prompt passing for Bedrock by passing a single string prompt for … (
f8f9488 
#1490) (#1496)

* Fix prompt passing for Bedrock by passing a single string prompt for Bedrock models. (#1476)

Signed-off-by: Austin Lee <[email protected]>

* Add unit tests, apply Spotless.

Signed-off-by: Austin Lee <[email protected]>

* Check if systemPrompt is null.

Signed-off-by: Austin Lee <[email protected]>

* Address review comments.

Signed-off-by: Austin Lee <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit e18f249)

Co-authored-by: Austin Lee <[email protected]>
dhrubo-os pushed a commit that referenced this issue Oct 11, 2023
@opensearch-trigger-bot @austintlee
Fix prompt passing for Bedrock by passing a single string prompt for … (
89f9b85 
#1490) (#1497)

* Fix prompt passing for Bedrock by passing a single string prompt for Bedrock models. (#1476)

Signed-off-by: Austin Lee <[email protected]>

* Add unit tests, apply Spotless.

Signed-off-by: Austin Lee <[email protected]>

* Check if systemPrompt is null.

Signed-off-by: Austin Lee <[email protected]>

* Address review comments.

Signed-off-by: Austin Lee <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit e18f249)

Co-authored-by: Austin Lee <[email protected]>
@ylwu-amzn
Copy link
Collaborator

@austintlee , is this issue resolved by the PR #1490 ?

@austintlee
Copy link
Collaborator Author

Yes. I will close this issue.

TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this issue Nov 21, 2023
@opensearch-trigger-bot @austintlee @TrungBui59
Fix prompt passing for Bedrock by passing a single string prompt for … (
5110816 
opensearch-project#1490) (opensearch-project#1497)

* Fix prompt passing for Bedrock by passing a single string prompt for Bedrock models. (opensearch-project#1476)

Signed-off-by: Austin Lee <[email protected]>

* Add unit tests, apply Spotless.

Signed-off-by: Austin Lee <[email protected]>

* Check if systemPrompt is null.

Signed-off-by: Austin Lee <[email protected]>

* Address review comments.

Signed-off-by: Austin Lee <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit e18f249)

Co-authored-by: Austin Lee <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request untriaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@austintlee @ylwu-amzn