fix failed ut

Signed-off-by: Yaliang Wu <[email protected]>
opensearch-project · Jul 11, 2023 · e20dc0b · e20dc0b
1 parent d766df9
commit e20dc0b
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/plugin/src/test/java/org/opensearch/ml/helper/ModelAccessControlHelperTests.java b/plugin/src/test/java/org/opensearch/ml/helper/ModelAccessControlHelperTests.java
@@ -199,8 +199,12 @@ public void test_IsOwner() {
     public void test_IsUserHasBackendRole() {
         User user = User.parse("owner|IT,HR|all_access");
         MLModelGroupBuilder builder = MLModelGroup.builder();
-        assertTrue(modelAccessControlHelper.isUserHasBackendRole(null, builder.access(AccessMode.PUBLIC.getValue()).build()));
-        assertFalse(modelAccessControlHelper.isUserHasBackendRole(null, builder.access(AccessMode.PRIVATE.getValue()).build()));
+        assertTrue(
+            modelAccessControlHelper.isUserHasBackendRole(null, builder.name("test_group").access(AccessMode.PUBLIC.getValue()).build())
+        );
+        assertFalse(
+            modelAccessControlHelper.isUserHasBackendRole(null, builder.name("test_group").access(AccessMode.PRIVATE.getValue()).build())
+        );
         assertTrue(
             modelAccessControlHelper
                 .isUserHasBackendRole(
@@ -218,9 +222,13 @@ public void test_IsOwnerStillHasPermission() {
         User userLostAccess = User.parse("owner|Finance|myTenant");
         assertTrue(modelAccessControlHelper.isOwnerStillHasPermission(null, null));
         MLModelGroupBuilder builder = MLModelGroup.builder();
-        assertTrue(modelAccessControlHelper.isOwnerStillHasPermission(user, builder.access(AccessMode.PUBLIC.getValue()).build()));
         assertTrue(
-            modelAccessControlHelper.isOwnerStillHasPermission(user, builder.access(AccessMode.PRIVATE.getValue()).owner(owner).build())
+            modelAccessControlHelper
+                .isOwnerStillHasPermission(user, builder.name("test_group").access(AccessMode.PUBLIC.getValue()).build())
+        );
+        assertTrue(
+            modelAccessControlHelper
+                .isOwnerStillHasPermission(user, builder.name("test_group").access(AccessMode.PRIVATE.getValue()).owner(owner).build())
         );
         assertFalse(
             modelAccessControlHelper