feat: replace dash with em dash

Signed-off-by: Lin Wang <[email protected]>
opensearch-project · Aug 31, 2023 · b423c44 · b423c44
1 parent 9bbd25f
commit b423c44
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/public/components/monitoring/model_deployment_table.tsx b/public/components/monitoring/model_deployment_table.tsx
@@ -97,7 +97,7 @@ export const ModelDeploymentTable = ({
         truncateText: true,
         textOnly: true,
         render: (_id: string, modelDeploymentItem: ModelDeploymentItem) => {
-          return modelDeploymentItem.connector?.name || '-';
+          return modelDeploymentItem.connector?.name || '\u2014';
         },
       },
       {
@@ -115,7 +115,7 @@ export const ModelDeploymentTable = ({
             respondingNodesCount === undefined ||
             notRespondingNodesCount === undefined
           ) {
-            return '-';
+            return '\u2014';
           }
           if (respondingNodesCount === 0) {
             return (

diff --git a/public/components/monitoring/tests/model_deployment_table.test.tsx b/public/components/monitoring/tests/model_deployment_table.test.tsx
@@ -137,8 +137,8 @@ describe('<DeployedModelTable />', () => {
       expect(within(header).getByText('Connector name')).toBeInTheDocument();
       expect(columnContent?.length).toBe(3);
       const cells = columnContent!;
-      expect(within(cells[0] as HTMLElement).getByText('-')).toBeInTheDocument();
-      expect(within(cells[1] as HTMLElement).getByText('-')).toBeInTheDocument();
+      expect(within(cells[0] as HTMLElement).getByText('\u2014')).toBeInTheDocument();
+      expect(within(cells[1] as HTMLElement).getByText('\u2014')).toBeInTheDocument();
       expect(within(cells[2] as HTMLElement).getByText('Sagemaker')).toBeInTheDocument();
     });
 

diff --git a/public/components/preview_panel/__tests__/connector_details.test.tsx b/public/components/preview_panel/__tests__/connector_details.test.tsx
@@ -22,9 +22,9 @@ describe('<ConnectorDetails />', () => {
     expect(screen.getByText('Connector description')).toBeInTheDocument();
   });
 
-  it('should render - when id is empty', () => {
+  it('should render em dash when id is empty', () => {
     setup({ id: '' });
-    expect(screen.getByText('-')).toBeInTheDocument();
+    expect(screen.getByText('\u2014')).toBeInTheDocument();
     expect(screen.queryByTestId('copyable-text-div')).not.toBeInTheDocument();
   });
 

diff --git a/public/components/preview_panel/connector_details.tsx b/public/components/preview_panel/connector_details.tsx
@@ -44,7 +44,7 @@ export const ConnectorDetails = (props: { name?: string; id?: string; descriptio
               {id ? (
                 <CopyableText text={id} iconLeft={false} tooltipText="Copy connector ID" />
               ) : (
-                '-'
+                '\u2014'
               )}
             </EuiDescriptionListDescription>
           </EuiFlexItem>