Add vector tile generation docker resources #15
Conversation
Signed-off-by: Junqiu Lei <[email protected]>
| # Copyright OpenSearch Contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| if [ "$1" == "generate" ]; then |
There was a problem hiding this comment.
Shall we add help command to display supported options ?
There was a problem hiding this comment.
I plan to create a document file to explain usages
There was a problem hiding this comment.
Why not include this inside script only?
| // Copyright OpenSearch Contributors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // In order to support add metadata 'Content-Encoding=gzip' and 'Content-Type=application/x-protobuf' on copy command, |
There was a problem hiding this comment.
Did you try extending from library instead of copying complete src code?
There was a problem hiding this comment.
Offline discussed with Vijay, it can't be used by extending from library due to method not public. And I will keep the existing method that replacing some codebase and build them in docker. I will also create a github issue on s5cmd repo to support the feature.
| cd /mbutil-0.3.0 && \ | ||
| python3 setup.py install | ||
|
|
||
| RUN wget -O s5cmd.tar.gz https://github.com/peak/s5cmd/archive/refs/tags/v2.0.0-beta.2.tar.gz && \ |
There was a problem hiding this comment.
Do we need to depend on beta version?
There was a problem hiding this comment.
Since 2.0 has some bug fixes and improvements, in our case it's stable enough to use the copy operation, and before 2.0 beta, the 1.4 was released last year Sep 21, 2021. https://github.com/peak/s5cmd/releases
Signed-off-by: Junqiu Lei <[email protected]>
|
@navneet1v yes, adding the docker resources is the first step, then I will add the docker resources to ECS CDK resources to make it a one stop executable task on ECS. Example here |
Signed-off-by: Junqiu Lei <[email protected]>
|
Since we changed the CDK stack name, the github actions test CDK will be failed, and I have updated the actions workflow in this PR as well. |
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei [email protected]
Description
There are there main parts on the container task workflow:
The ECS task execution workflow: here
Issues Resolved
#12
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.