Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing unit test for Faiss due to faiss upgrade. #951

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

navneet1v
Copy link
Collaborator

Description

Fixing unit test for Faiss due to faiss upgrade.

Issues Resolved

NA

16:51 ~/workplace/k-NN/jni faiss-unit$ ./bin/jni_test
Running main() from /Users/navneev/workplace/k-NN/jni/googletest-src/googletest/src/gtest_main.cc
[==========] Running 12 tests from 12 test suites.
[----------] Global test environment set-up.
[----------] 1 test from FaissCreateIndexTest
[ RUN      ] FaissCreateIndexTest.BasicAssertions
[       OK ] FaissCreateIndexTest.BasicAssertions (11 ms)
[----------] 1 test from FaissCreateIndexTest (11 ms total)

[----------] 1 test from FaissCreateIndexFromTemplateTest
[ RUN      ] FaissCreateIndexFromTemplateTest.BasicAssertions
[       OK ] FaissCreateIndexFromTemplateTest.BasicAssertions (5 ms)
[----------] 1 test from FaissCreateIndexFromTemplateTest (5 ms total)

[----------] 1 test from FaissLoadIndexTest
[ RUN      ] FaissLoadIndexTest.BasicAssertions
[       OK ] FaissLoadIndexTest.BasicAssertions (6 ms)
[----------] 1 test from FaissLoadIndexTest (6 ms total)

[----------] 1 test from FaissQueryIndexTest
[ RUN      ] FaissQueryIndexTest.BasicAssertions
[       OK ] FaissQueryIndexTest.BasicAssertions (93 ms)
[----------] 1 test from FaissQueryIndexTest (93 ms total)

[----------] 1 test from FaissFreeTest
[ RUN      ] FaissFreeTest.BasicAssertions
[       OK ] FaissFreeTest.BasicAssertions (0 ms)
[----------] 1 test from FaissFreeTest (0 ms total)

[----------] 1 test from FaissInitLibraryTest
[ RUN      ] FaissInitLibraryTest.BasicAssertions
[       OK ] FaissInitLibraryTest.BasicAssertions (0 ms)
[----------] 1 test from FaissInitLibraryTest (0 ms total)

[----------] 1 test from FaissTrainIndexTest
[ RUN      ] FaissTrainIndexTest.BasicAssertions
[       OK ] FaissTrainIndexTest.BasicAssertions (19 ms)
[----------] 1 test from FaissTrainIndexTest (19 ms total)

[----------] 1 test from NmslibCreateIndexTest
[ RUN      ] NmslibCreateIndexTest.BasicAssertions
[       OK ] NmslibCreateIndexTest.BasicAssertions (9 ms)
[----------] 1 test from NmslibCreateIndexTest (9 ms total)

[----------] 1 test from NmslibLoadIndexTest
[ RUN      ] NmslibLoadIndexTest.BasicAssertions
[       OK ] NmslibLoadIndexTest.BasicAssertions (8 ms)
[----------] 1 test from NmslibLoadIndexTest (8 ms total)

[----------] 1 test from NmslibQueryIndexTest
[ RUN      ] NmslibQueryIndexTest.BasicAssertions
[       OK ] NmslibQueryIndexTest.BasicAssertions (17 ms)
[----------] 1 test from NmslibQueryIndexTest (17 ms total)

[----------] 1 test from NmslibFreeTest
[ RUN      ] NmslibFreeTest.BasicAssertions
[       OK ] NmslibFreeTest.BasicAssertions (7 ms)
[----------] 1 test from NmslibFreeTest (7 ms total)

[----------] 1 test from NmslibInitLibraryTest
[ RUN      ] NmslibInitLibraryTest.BasicAssertions
[       OK ] NmslibInitLibraryTest.BasicAssertions (0 ms)
[----------] 1 test from NmslibInitLibraryTest (0 ms total)

[----------] Global test environment tear-down
[==========] 12 tests from 12 test suites ran. (179 ms total)
[  PASSED  ] 12 tests.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #951 (6da1526) into main (b84250e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #951   +/-   ##
=========================================
  Coverage     85.08%   85.08%           
  Complexity     1112     1112           
=========================================
  Files           152      152           
  Lines          4520     4520           
  Branches        406      406           
=========================================
  Hits           3846     3846           
  Misses          489      489           
  Partials        185      185           

@navneet1v navneet1v merged commit d55eccb into opensearch-project:main Jul 4, 2023
@navneet1v navneet1v deleted the faiss-unit branch July 4, 2023 01:49
navneet1v added a commit to navneet1v/k-NN that referenced this pull request Jul 10, 2023
navneet1v added a commit to navneet1v/k-NN that referenced this pull request Jul 10, 2023
navneet1v added a commit that referenced this pull request Jul 10, 2023
naveentatikonda pushed a commit to naveentatikonda/k-NN that referenced this pull request Jul 11, 2023
naveentatikonda pushed a commit to naveentatikonda/k-NN that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants