Add CHANGELOG #800
Add CHANGELOG #800
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #800 +/- ##
============================================
- Coverage 85.40% 85.08% -0.33%
+ Complexity 1084 1076 -8
============================================
Files 151 151
Lines 4370 4370
Branches 390 390
============================================
- Hits 3732 3718 -14
- Misses 463 475 +12
- Partials 175 177 +2 see 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
heemin32
force-pushed
the
changelog
branch
2 times, most recently
from
5ea4fde to
39c1f77
Compare
|
|
||
| - uses: dangoslen/changelog-enforcer@v3 | ||
| with: | ||
| skipLabels: "autocut, skip-changelog" |
There was a problem hiding this comment.
why autocut is included? We can add "skip-changelog" to autocuts if needed.
There was a problem hiding this comment.
Followed what OpenSearch core repo is doing. I think most of commit done by auto cut won't get included in CHANGELOG. Yes. Adding skip-changelog in the autocut might be better if some of the autocut need to get included in the CHANGELOG. Do we have such case do you know?
There was a problem hiding this comment.
I don't have any particular reference, but I can image it's could be a fix for a broken distribution build, or other type of infrastructure change, like build/publish script
There was a problem hiding this comment.
I'm fine with having auto-cut if that what core is doing, we can revert it later if that doesn't work for us. Just want to understand the reason behind adding it
There was a problem hiding this comment.
The reason that we don't include autocut here is because I don't see a case where we need to update CHANGELOG for autocut PR. Agree, we can change it later if we see the need of it.
Signed-off-by: Heemin Kim <[email protected]>
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 8c616fc)
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 8c616fc) Co-authored-by: Heemin Kim <[email protected]>
Description
Add CHANGELOG
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.