Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Change initial size of DocIdSetBuilder #753

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 586958e from #502

Changes initial size of the docidsetbuilder used for iterating over results for k-NN queries. Originally, it was set to the maximum docid. This changes it to be the number of docs returned.

Signed-off-by: John Mazanec <[email protected]>
(cherry picked from commit 586958e)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team February 7, 2023 19:35
@martin-gaievski
Copy link
Member

This fixes #751

@codecov-commenter
Copy link

Codecov Report

Merging #753 (3ce7809) into 1.x (417e988) will decrease coverage by 0.29%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                1.x     #753      +/-   ##
============================================
- Coverage     84.17%   83.88%   -0.29%     
+ Complexity      906      900       -6     
============================================
  Files           127      127              
  Lines          3879     3879              
  Branches        359      359              
============================================
- Hits           3265     3254      -11     
- Misses          455      464       +9     
- Partials        159      161       +2     
Impacted Files Coverage Δ
.../main/java/org/opensearch/knn/index/KNNWeight.java 77.92% <100.00%> (ø)
...va/org/opensearch/knn/index/KNNCircuitBreaker.java 60.00% <0.00%> (-20.00%) ⬇️
...ain/java/org/opensearch/knn/index/KNNSettings.java 80.88% <0.00%> (-2.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@martin-gaievski martin-gaievski merged commit 92fdb44 into 1.x Feb 7, 2023
@github-actions github-actions bot deleted the backport/backport-502-to-1.x branch February 7, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants