Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codec version to 9.5 #747

Conversation

naveentatikonda
Copy link
Member

@naveentatikonda naveentatikonda commented Feb 2, 2023

Signed-off-by: Naveen Tatikonda [email protected]

Description

This PR includes the following changes:

Issues Resolved

#745

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naveen Tatikonda <[email protected]>
@naveentatikonda naveentatikonda requested a review from a team February 2, 2023 22:02
martin-gaievski and others added 2 commits February 2, 2023 16:28
* Add Lucene 9.5 codec and make it new default

Signed-off-by: Martin Gaievski <[email protected]>
Updates tests for backwards codecs to prevent backwards codecs from
writing with a read only codec.

Signed-off-by: John Mazanec <[email protected]>
@naveentatikonda naveentatikonda changed the title Update lucene94 package Update lucene94 package and Add Lucene 95 Codec Feb 2, 2023
@naveentatikonda naveentatikonda added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Feb 2, 2023
@martin-gaievski
Copy link
Member

For tracking purposes - we're making this change after core recently has switched to Lucene 9.5

Copy link
Member

@jmazanec15 jmazanec15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we rename PR "Update codec version to 9.5" for release notes purposes?

Also, does this need to be ported forward to main?

@naveentatikonda
Copy link
Member Author

Looks good. Can we rename PR "Update codec version to 9.5" for release notes purposes?

Also, does this need to be ported forward to main?

Sure will update the title. The changes are already on main

@naveentatikonda naveentatikonda changed the title Update lucene94 package and Add Lucene 95 Codec Update codec version to 9.5 Feb 3, 2023
@naveentatikonda naveentatikonda merged commit 2a40da4 into opensearch-project:2.x Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants