Update bwc to 2.6.0-SNAPSHOT #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
added
the
Infrastructure
Codecov Report
@@ Coverage Diff @@
## main #723 +/- ##
=========================================
Coverage 84.39% 84.39%
Complexity 1067 1067
=========================================
Files 151 151
Lines 4345 4345
Branches 389 389
=========================================
Hits 3667 3667
Misses 498 498
Partials 180 180 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
navneet1v
reviewed
Jan 17, 2023
| @@ -14,7 +14,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| java: [ 11, 17 ] | |||
| bwc_version : [ "2.0.1", "2.1.0", "2.2.1", "2.3.0", "2.4.1", "2.5.0-SNAPSHOT" ] | |||
| bwc_version : [ "2.0.1", "2.1.0", "2.2.1", "2.3.0", "2.4.1", "2.5.0-SNAPSHOT", "2.6.0-SNAPSHOT" ] | |||
There was a problem hiding this comment.
should we put the version with a suffix : -SNAPSHOT? Is there a better way to keep this bwc_version list clean?
There was a problem hiding this comment.
Seems like 2.5.0 is not released as of now. Let's make sure that once it is released we are removing the -SNAPSHOT suffix.
heemin32
approved these changes
Jan 17, 2023
navneet1v
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade main to use 2.6 snapshot for bwc
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.