-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix #692
Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix #692
Conversation
…ontent Bugfix Signed-off-by: Naveen Tatikonda <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #692 +/- ##
============================================
+ Coverage 84.46% 84.49% +0.02%
- Complexity 1055 1059 +4
============================================
Files 149 149
Lines 4307 4320 +13
Branches 385 389 +4
============================================
+ Hits 3638 3650 +12
- Misses 489 490 +1
Partials 180 180
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thx
src/test/java/org/opensearch/knn/indices/ModelGraveyardTests.java
Outdated
Show resolved
Hide resolved
e902958
to
8667093
Compare
src/test/java/org/opensearch/knn/indices/ModelGraveyardTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Naveen Tatikonda <[email protected]>
8667093
to
34e4fec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the changes, as I can see some cosmetic comments on the code.
…ontent Bugfix (#692) * Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix Signed-off-by: Naveen Tatikonda <[email protected]> * Address Review Comments Signed-off-by: Naveen Tatikonda <[email protected]> Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit fcd2d55)
…ontent Bugfix (#692) * Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix Signed-off-by: Naveen Tatikonda <[email protected]> * Address Review Comments Signed-off-by: Naveen Tatikonda <[email protected]> Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit fcd2d55)
…ontent Bugfix (#692) * Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix Signed-off-by: Naveen Tatikonda <[email protected]> * Address Review Comments Signed-off-by: Naveen Tatikonda <[email protected]> Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit fcd2d55)
…ontent Bugfix (#692) * Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix Signed-off-by: Naveen Tatikonda <[email protected]> * Address Review Comments Signed-off-by: Naveen Tatikonda <[email protected]> Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit fcd2d55)
…ontent Bugfix (#692) (#697) * Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix Signed-off-by: Naveen Tatikonda <[email protected]> * Address Review Comments Signed-off-by: Naveen Tatikonda <[email protected]> Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit fcd2d55) Co-authored-by: Naveen Tatikonda <[email protected]>
…ontent Bugfix (#692) (#696) * Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix Signed-off-by: Naveen Tatikonda <[email protected]> * Address Review Comments Signed-off-by: Naveen Tatikonda <[email protected]> Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit fcd2d55) Co-authored-by: Naveen Tatikonda <[email protected]>
…ontent Bugfix (#692) (#695) * Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix Signed-off-by: Naveen Tatikonda <[email protected]> * Address Review Comments Signed-off-by: Naveen Tatikonda <[email protected]> Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit fcd2d55) Co-authored-by: Naveen Tatikonda <[email protected]>
…ontent Bugfix (#692) (#694) * Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix Signed-off-by: Naveen Tatikonda <[email protected]> * Address Review Comments Signed-off-by: Naveen Tatikonda <[email protected]> Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit fcd2d55) Co-authored-by: Naveen Tatikonda <[email protected]>
Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix
Signed-off-by: Naveen Tatikonda [email protected]
Description
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.