Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix #692

Merged

Conversation

naveentatikonda
Copy link
Member

Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix

Signed-off-by: Naveen Tatikonda [email protected]

Description

  • Update ModelGraveyard fromXContent logic to add backward compatibility to those domains that have parsed the old toXContent logic.
  • Add more validations in fromXContent logic.
  • Add more test cases to validate them

Check List

  • New functionality includes testing.
    • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveentatikonda naveentatikonda added Bug Fixes Changes to a system or product designed to handle a programming bug/glitch backport 2.x backport 2.3 Backport to 2.3 branch backport 2.4 backport to 2.4 branch backport 2.2 labels Dec 22, 2022
@naveentatikonda naveentatikonda self-assigned this Dec 22, 2022
@naveentatikonda naveentatikonda requested a review from a team December 22, 2022 20:17
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #692 (e902958) into main (c412c8a) will increase coverage by 0.02%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##               main     #692      +/-   ##
============================================
+ Coverage     84.46%   84.49%   +0.02%     
- Complexity     1055     1059       +4     
============================================
  Files           149      149              
  Lines          4307     4320      +13     
  Branches        385      389       +4     
============================================
+ Hits           3638     3650      +12     
- Misses          489      490       +1     
  Partials        180      180              
Impacted Files Coverage Δ
...ava/org/opensearch/knn/indices/ModelGraveyard.java 90.58% <88.88%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx

Signed-off-by: Naveen Tatikonda <[email protected]>
Copy link
Collaborator

@navneet1v navneet1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes, as I can see some cosmetic comments on the code.

@naveentatikonda naveentatikonda merged commit fcd2d55 into opensearch-project:main Dec 23, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 23, 2022
…ontent Bugfix (#692)

* Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit fcd2d55)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 23, 2022
…ontent Bugfix (#692)

* Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit fcd2d55)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 23, 2022
…ontent Bugfix (#692)

* Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit fcd2d55)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 23, 2022
…ontent Bugfix (#692)

* Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit fcd2d55)
naveentatikonda added a commit that referenced this pull request Dec 23, 2022
…ontent Bugfix (#692) (#697)

* Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit fcd2d55)

Co-authored-by: Naveen Tatikonda <[email protected]>
naveentatikonda added a commit that referenced this pull request Dec 23, 2022
…ontent Bugfix (#692) (#696)

* Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit fcd2d55)

Co-authored-by: Naveen Tatikonda <[email protected]>
naveentatikonda added a commit that referenced this pull request Dec 23, 2022
…ontent Bugfix (#692) (#695)

* Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit fcd2d55)

Co-authored-by: Naveen Tatikonda <[email protected]>
naveentatikonda added a commit that referenced this pull request Dec 23, 2022
…ontent Bugfix (#692) (#694)

* Add Backward Compatibility and Validation checks to ModelGraveyard XContent Bugfix

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit fcd2d55)

Co-authored-by: Naveen Tatikonda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.2 backport 2.3 Backport to 2.3 branch backport 2.4 backport to 2.4 branch Bug Fixes Changes to a system or product designed to handle a programming bug/glitch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants